Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2248913002: bluetooth: Implement RSSI and Tx Power on macOS and Android (Closed)

Created:
4 years, 4 months ago by ortuno
Modified:
4 years, 3 months ago
Reviewers:
Jeffrey Yasskin, scheib
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth-refactor-adv-data
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Implement RSSI and Tx Power on macOS and Android Implements GetInquiryRSSI and GetInquiryTxPower on macOS and Android. BUG=568135 Committed: https://crrev.com/cc9b46d1d495acb0e23a6e1c607f79d7c61ae18b Cr-Commit-Position: refs/heads/master@{#414457}

Patch Set 1 #

Patch Set 2 : Format #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Clean up #

Total comments: 24

Patch Set 6 : Address most comments #

Patch Set 7 : Clean up test #

Patch Set 8 : Fix mac test #

Total comments: 3

Patch Set 9 : Address jyasskin's comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+415 lines, -338 lines) Patch
M device/BUILD.gn View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java View 2 chunks +4 lines, -2 lines 0 comments Download
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android.h View 1 chunk +3 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_android.cc View 1 2 3 4 5 6 7 8 2 chunks +12 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.mm View 1 2 3 4 5 6 7 8 1 chunk +9 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device.h View 1 2 3 4 5 6 7 8 4 chunks +18 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_device.cc View 1 2 3 3 chunks +34 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device_android.cc View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M device/bluetooth/bluetooth_device_unittest.cc View 1 2 3 4 5 6 7 10 chunks +203 lines, -260 lines 2 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 1 chunk +0 lines, -10 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_device_bluez.cc View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java View 1 2 3 4 5 8 chunks +38 lines, -11 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 1 2 3 4 5 2 chunks +53 lines, -14 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_mac.mm View 1 2 3 4 5 6 6 chunks +24 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 36 (26 generated)
ortuno
jyasskin: PTAL
4 years, 4 months ago (2016-08-23 19:12:29 UTC) #3
Jeffrey Yasskin
https://codereview.chromium.org/2248913002/diff/80001/device/bluetooth/bluetooth_adapter_android.cc File device/bluetooth/bluetooth_adapter_android.cc (right): https://codereview.chromium.org/2248913002/diff/80001/device/bluetooth/bluetooth_adapter_android.cc#newcode216 device/bluetooth/bluetooth_adapter_android.cc:216: // Android uses INT32_MIN to indicate no Advertised Tx ...
4 years, 4 months ago (2016-08-24 04:32:02 UTC) #7
ortuno
https://codereview.chromium.org/2248913002/diff/80001/device/bluetooth/bluetooth_adapter_android.cc File device/bluetooth/bluetooth_adapter_android.cc (right): https://codereview.chromium.org/2248913002/diff/80001/device/bluetooth/bluetooth_adapter_android.cc#newcode216 device/bluetooth/bluetooth_adapter_android.cc:216: // Android uses INT32_MIN to indicate no Advertised Tx ...
4 years, 4 months ago (2016-08-24 21:29:09 UTC) #12
Jeffrey Yasskin
lgtm https://codereview.chromium.org/2248913002/diff/80001/device/bluetooth/bluetooth_adapter_android.cc File device/bluetooth/bluetooth_adapter_android.cc (right): https://codereview.chromium.org/2248913002/diff/80001/device/bluetooth/bluetooth_adapter_android.cc#newcode225 device/bluetooth/bluetooth_adapter_android.cc:225: clamped_tx_power ? &clamped_tx_power.value() : nullptr); On 2016/08/24 21:29:09, ...
4 years, 4 months ago (2016-08-24 22:32:07 UTC) #17
ortuno
Thanks! https://codereview.chromium.org/2248913002/diff/80001/device/bluetooth/bluetooth_adapter_android.cc File device/bluetooth/bluetooth_adapter_android.cc (right): https://codereview.chromium.org/2248913002/diff/80001/device/bluetooth/bluetooth_adapter_android.cc#newcode225 device/bluetooth/bluetooth_adapter_android.cc:225: clamped_tx_power ? &clamped_tx_power.value() : nullptr); On 2016/08/24 at ...
4 years, 3 months ago (2016-08-25 16:42:34 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248913002/200001
4 years, 3 months ago (2016-08-25 16:43:15 UTC) #30
commit-bot: I haz the power
Committed patchset #9 (id:200001)
4 years, 3 months ago (2016-08-25 16:47:42 UTC) #31
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/cc9b46d1d495acb0e23a6e1c607f79d7c61ae18b Cr-Commit-Position: refs/heads/master@{#414457}
4 years, 3 months ago (2016-08-25 16:51:18 UTC) #33
scheib
https://codereview.chromium.org/2248913002/diff/200001/device/bluetooth/bluetooth_device_unittest.cc File device/bluetooth/bluetooth_device_unittest.cc (right): https://codereview.chromium.org/2248913002/diff/200001/device/bluetooth/bluetooth_device_unittest.cc#newcode139 device/bluetooth/bluetooth_device_unittest.cc:139: // http://crbug.com/639408 BTW I think we should stick with ...
4 years, 3 months ago (2016-08-29 02:58:13 UTC) #35
ortuno
4 years, 3 months ago (2016-08-29 15:53:58 UTC) #36
Message was sent while issue was closed.
https://codereview.chromium.org/2248913002/diff/200001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_device_unittest.cc (right):

https://codereview.chromium.org/2248913002/diff/200001/device/bluetooth/bluet...
device/bluetooth/bluetooth_device_unittest.cc:139: // http://crbug.com/639408
On 2016/08/29 at 02:58:13, scheib wrote:
> BTW I think we should stick with TODO(639408) style, instead of
TODO(username).

Acknowledged.

Powered by Google App Engine
This is Rietveld 408576698