Issue 22455003: Make FunctionTypeMirror and ClosureMirror handle user-defined classes that implement the call opera…

Issue 22455003: Make FunctionTypeMirror and ClosureMirror handle user-defined classes that implement the call opera… (Closed)

Created:
7 years, 4 months ago by rmacnak

Modified:
7 years, 4 months ago

Reviewers:
ahe, siva

CC:
reviews_dartlang.org, Michael Lippautz (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make FunctionTypeMirror and ClosureMirror handle user-defined classes that implement call and their instances respectively.

Patch Set 2 : call is no longer an operator #

Total comments: 3

Patch Set 3 : Assert call method of function type not null #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -22 lines)			Patch
M	runtime/lib/mirrors.cc	View	1 2	5 chunks	+54 lines, -8 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View		4 chunks	+30 lines, -12 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/symbols.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/lib/lib.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/lib/mirrors/fake_function_test.dart	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rmacnak

https://chromiumcodereview.appspot.com/22455003/diff/17001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://chromiumcodereview.appspot.com/22455003/diff/17001/runtime/lib/mirrors.cc#newcode163 runtime/lib/mirrors.cc:163: static RawFunction* CallMethod(const Class& cls) { Compare Instance::IsCallable(). https://chromiumcodereview.appspot.com/22455003/diff/17001/runtime/lib/mirrors.cc#newcode769 ...

7 years, 4 months ago (2013-08-06 20:22:31 UTC) #1

ahe

Test LGTM https://chromiumcodereview.appspot.com/22455003/diff/17001/tests/lib/mirrors/fake_function_test.dart File tests/lib/mirrors/fake_function_test.dart (right): https://chromiumcodereview.appspot.com/22455003/diff/17001/tests/lib/mirrors/fake_function_test.dart#newcode32 tests/lib/mirrors/fake_function_test.dart:32: // Expect.isTrue(mm.isOperator); I don't think call is ...

7 years, 4 months ago (2013-08-06 20:32:46 UTC) #2

rmacnak

https://chromiumcodereview.appspot.com/22455003/diff/17001/tests/lib/mirrors/fake_function_test.dart File tests/lib/mirrors/fake_function_test.dart (right): https://chromiumcodereview.appspot.com/22455003/diff/17001/tests/lib/mirrors/fake_function_test.dart#newcode32 tests/lib/mirrors/fake_function_test.dart:32: // Expect.isTrue(mm.isOperator); On 2013/08/06 20:32:46, ahe wrote: > I ...

7 years, 4 months ago (2013-08-06 20:38:02 UTC) #3

siva

https://chromiumcodereview.appspot.com/22455003/diff/21001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://chromiumcodereview.appspot.com/22455003/diff/21001/runtime/lib/mirrors.cc#newcode370 runtime/lib/mirrors.cc:370: return CreateParameterMirrorList(func); Does CreateParameterMirrorList deal with func being null? ...

7 years, 4 months ago (2013-08-06 23:32:07 UTC) #4

rmacnak

7 years, 4 months ago (2013-08-07 00:10:21 UTC) #5

lgtm

Expand Messages | Collapse Messages