Issue 22429005: Normalize parameters to AdbClientSocket::CommandCallback parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22429005: Normalize parameters to AdbClientSocket::CommandCallback parameters (Closed)

Created:
7 years, 4 months ago by Vladislav Kaznacheev

Modified:
7 years, 4 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Normalize parameters to AdbClientSocket::CommandCallback parameters The 1st parameter (result) currently has unclear meaning. Sometimes it is used as a network result (such as net::OK) and sometimes as the offset of the content in the 2nd parameter (response). This patch removes the confusion. result is always network error code and the response is always the response content (empty if result is an error) BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216175

Patch Set 1 #

Patch Set 2 : Added a TODO #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	chrome/browser/devtools/adb_client_socket.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/devtools/devtools_adb_bridge.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/22429005/1

7 years, 4 months ago (2013-08-07 09:50:26 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/22429005/1003

7 years, 4 months ago (2013-08-07 10:28:42 UTC) #5

Message was sent while issue was closed.

Change committed as 216175

Expand Messages | Collapse Messages