Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: chrome/browser/devtools/devtools_adb_bridge.cc

Issue 22429005: Normalize parameters to AdbClientSocket::CommandCallback parameters (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added a TODO Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/adb_client_socket.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_adb_bridge.cc
diff --git a/chrome/browser/devtools/devtools_adb_bridge.cc b/chrome/browser/devtools/devtools_adb_bridge.cc
index 3ce82bb337a858f6446f0669af5078246be41f14..3b9dd6a4d746fa3fc9ab50142459e966d33a42fe 100644
--- a/chrome/browser/devtools/devtools_adb_bridge.cc
+++ b/chrome/browser/devtools/devtools_adb_bridge.cc
@@ -276,8 +276,7 @@ class AdbPagesCommand : public base::RefCountedThreadSafe<
}
// Parse version, append to package name if available,
- std::string body = response.substr(result);
- scoped_ptr<base::Value> value(base::JSONReader::Read(body));
+ scoped_ptr<base::Value> value(base::JSONReader::Read(response));
base::DictionaryValue* dict;
if (value && value->GetAsDictionary(&dict)) {
std::string browser;
@@ -303,8 +302,7 @@ class AdbPagesCommand : public base::RefCountedThreadSafe<
return;
}
- std::string body = response.substr(result);
- scoped_ptr<base::Value> value(base::JSONReader::Read(body));
+ scoped_ptr<base::Value> value(base::JSONReader::Read(response));
base::ListValue* list_value;
if (!value || !value->GetAsList(&list_value)) {
ProcessSockets();
« no previous file with comments | « chrome/browser/devtools/adb_client_socket.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698