Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 22417004: [pkg:polymer] add support for bool/int/double/String attributes (Closed)

Created:
6 years, 10 months ago by Jennifer Messerly
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org, sethladd
Base URL:
https://github.com/dart-lang/web-ui.git@master
Visibility:
Public.

Description

add support for bool/int/double/String attributes BUG=

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M lib/polymer_element.dart View 1 chunk +18 lines, -5 lines 6 comments Download

Messages

Total messages: 7 (0 generated)
Jennifer Messerly
Needs a test. Maybe we can port from polymer.js?
6 years, 10 months ago (2013-08-06 16:26:55 UTC) #1
Jennifer Messerly
update title. String works too :)
6 years, 10 months ago (2013-08-06 16:31:17 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://chromiumcodereview.appspot.com/22417004/diff/1/lib/polymer_element.dart File lib/polymer_element.dart (right): https://chromiumcodereview.appspot.com/22417004/diff/1/lib/polymer_element.dart#newcode130 lib/polymer_element.dart:130: propObserver.value = int.parse(value, onError: (x) => null); should ...
6 years, 10 months ago (2013-08-06 16:40:39 UTC) #3
Jennifer Messerly
https://chromiumcodereview.appspot.com/22417004/diff/1/lib/polymer_element.dart File lib/polymer_element.dart (right): https://chromiumcodereview.appspot.com/22417004/diff/1/lib/polymer_element.dart#newcode130 lib/polymer_element.dart:130: propObserver.value = int.parse(value, onError: (x) => null); On 2013/08/06 ...
6 years, 10 months ago (2013-08-06 16:44:23 UTC) #4
Siggi Cherem (dart-lang)
https://chromiumcodereview.appspot.com/22417004/diff/1/lib/polymer_element.dart File lib/polymer_element.dart (right): https://chromiumcodereview.appspot.com/22417004/diff/1/lib/polymer_element.dart#newcode135 lib/polymer_element.dart:135: propObserver.value = value; On 2013/08/06 16:44:23, John Messerly wrote: ...
6 years, 10 months ago (2013-08-06 16:46:00 UTC) #5
Jennifer Messerly
https://chromiumcodereview.appspot.com/22417004/diff/1/lib/polymer_element.dart File lib/polymer_element.dart (right): https://chromiumcodereview.appspot.com/22417004/diff/1/lib/polymer_element.dart#newcode130 lib/polymer_element.dart:130: propObserver.value = int.parse(value, onError: (x) => null); On 2013/08/06 ...
6 years, 10 months ago (2013-08-06 20:04:52 UTC) #6
Jennifer Messerly
6 years, 8 months ago (2013-10-03 20:52:51 UTC) #7
closing this, it was superseded by https://codereview.chromium.org/24149003/

Powered by Google App Engine
This is Rietveld 408576698