LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection_wsh.py - Issue 22375002: WebSocket must not be established when subprotocol is not selected by the server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection_wsh.py

Issue 22375002: WebSocket must not be established when subprotocol is not selected by the server (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix test description Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection-expected.txt ('k') | Source/modules/websockets/WebSocketHandshake.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection_wsh.py

diff --git a/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py b/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection_wsh.py

similarity index 92%

copy from LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py

copy to LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection_wsh.py

index ecfe41f32fcc23cb73c4f14d7abcfd676ba9b862..7c0e402a581311c6a7c7b52dc0fb4737d1326e85 100644

--- a/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py

+++ b/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-null-subprotocol-selection_wsh.py

@@ -7,7 +7,6 @@ def web_socket_do_extra_handshake(request):

message += 'Upgrade: websocket\r\n'

message += 'Connection: Upgrade\r\n'

message += 'Sec-WebSocket-Accept: %s\r\n' % compute_accept(request.headers_in['Sec-WebSocket-Key'])[0]

- message += 'Sec-WebSocket-Extensions: x-foo\r\n'

message += '\r\n'

request.connection.write(message)

raise handshake.AbortedByUserException('Abort the connection') # Prevents pywebsocket from sending its own handshake message.