Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: src/core/SkWriter32.cpp

Issue 22359003: allow NULL in writeString/readString (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: style nit Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/Writer32Test.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkWriter32.cpp
diff --git a/src/core/SkWriter32.cpp b/src/core/SkWriter32.cpp
index 56edd19698031ace0308c7a09bf1ad93585c600e..e41e2df0c470423c34d017bc51e324165d9ed19a 100644
--- a/src/core/SkWriter32.cpp
+++ b/src/core/SkWriter32.cpp
@@ -246,6 +246,12 @@ void SkWriter32::validate() const {
const char* SkReader32::readString(size_t* outLen) {
size_t len = this->readInt();
+ if (0xFFFF == len) {
+ if (outLen) {
+ *outLen = 0;
+ }
+ return NULL;
+ }
const void* ptr = this->peek();
// skip over teh string + '\0' and then pad to a multiple of 4
@@ -268,8 +274,12 @@ size_t SkReader32::readIntoString(SkString* copy) {
}
void SkWriter32::writeString(const char str[], size_t len) {
+ if (NULL == str) {
+ // We're already requiring len < 0xFFFF, so we can use that to mark NULL.
+ this->write32(0xFFFF);
+ return;
+ }
if ((long)len < 0) {
- SkASSERT(str);
len = strlen(str);
}
this->write32(len);
« no previous file with comments | « no previous file | tests/Writer32Test.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698