allow NULL in writeString/readString

src/core/SkWriter32.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkWriter32.h"
 
 SkWriter32::SkWriter32(size_t minSize, void* storage, size_t storageSize) {
@@ skipping 228 matching lines @@
 
 #include "SkReader32.h"
 #include "SkString.h"
 
 /*
  *  Strings are stored as: length[4-bytes] + string_data + '\0' + pad_to_mul_4
  */
 
 const char* SkReader32::readString(size_t* outLen) {
     size_t len = this->readInt();
+    if (0xFFFF == len) {
+        if (outLen) {
+            *outLen = 0;
+        }
+        return NULL;
+    }
     const void* ptr = this->peek();
 
     // skip over teh string + '\0' and then pad to a multiple of 4
     size_t alignedSize = SkAlign4(len + 1);
     this->skip(alignedSize);
 
     if (outLen) {
         *outLen = len;
     }
     return (const char*)ptr;
 }
 
 size_t SkReader32::readIntoString(SkString* copy) {
     size_t len;
     const char* ptr = this->readString(&len);
     if (copy) {
         copy->set(ptr, len);
     }
     return len;
 }
 
 void SkWriter32::writeString(const char str[], size_t len) {
+    if (NULL == str) {
+        // We're already requiring len < 0xFFFF, so we can use that to mark NULL.
+        this->write32(0xFFFF);
+        return;
+    }
     if ((long)len < 0) {
-        SkASSERT(str);
         len = strlen(str);
     }
     this->write32(len);
     // add 1 since we also write a terminating 0
     size_t alignedLen = SkAlign4(len + 1);
     char* ptr = (char*)this->reserve(alignedLen);
     {
         // Write the terminating 0 and fill in the rest with zeroes
         uint32_t* padding = (uint32_t*)(ptr + (alignedLen - 4));
         *padding = 0;
     }
     // Copy the string itself.
     memcpy(ptr, str, len);
 }
 
 size_t SkWriter32::WriteStringSize(const char* str, size_t len) {
     if ((long)len < 0) {
         SkASSERT(str);
         len = strlen(str);
     }
     const size_t lenBytes = 4;    // we use 4 bytes to record the length
     // add 1 since we also write a terminating 0
     return SkAlign4(lenBytes + len + 1);
 }