Expand UMA metrics for SSL (check history)

We want to know if users react differently to the SSL warning the first time they encounter a website with an SSL error vs on subsequent encounters with SSL warnings. We determine this by checking to see if a site is in the user's history.

BUG=255288
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216776

[felt, 2013-08-09 06:14:39]

Hi Chris, can you please review this CL?

The only thing of real note -- I use Profile::EXPLICIT_ACCESS when fetching the
history service, which means we check the history even if the user is in
Incognito mode. I think that's fine because we aren't recording anything
permanent, but just wanted to point it out.

Adrienne

[felt, 2013-08-09 06:15:05]

Alexei, can you review the (tiny) change to
tools/metrics/histograms/histograms.xml?

[palmer, 2013-08-09 17:38:14]

LGTM.

https://codereview.chromium.org/22350004/diff/3001/chrome/browser/ssl/ssl_blo...
File chrome/browser/ssl/ssl_blocking_page.h (right):

https://codereview.chromium.org/22350004/diff/3001/chrome/browser/ssl/ssl_blo...
chrome/browser/ssl/ssl_blocking_page.h:86: CancelableRequestConsumer
request_consumer_;  // Used for getting num_visits_.
Nit: I'd stick with the comment-above-declaration style.

[felt, 2013-08-09 17:39:57]

thanks chris

https://codereview.chromium.org/22350004/diff/3001/chrome/browser/ssl/ssl_blo...
File chrome/browser/ssl/ssl_blocking_page.h (right):

https://codereview.chromium.org/22350004/diff/3001/chrome/browser/ssl/ssl_blo...
chrome/browser/ssl/ssl_blocking_page.h:86: CancelableRequestConsumer
request_consumer_;  // Used for getting num_visits_.
On 2013/08/09 17:38:14, Chromium Palmer wrote:
> Nit: I'd stick with the comment-above-declaration style.

Done.

[Alexei Svitkine (slow), 2013-08-09 17:51:45]

histograms.xml lgtm

[commit-bot: I haz the power, 2013-08-09 17:54:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/22350004/13001

[commit-bot: I haz the power, 2013-08-09 23:32:39]

Change committed as 216776