Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6329)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 22350004: Expand UMA metrics for SSL (check history) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed comment nit Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_blocking_page.h
diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h
index af24412e2900e7bae3981013fb1aa187fc23ed70..d4703f477245843b63d02e12b96750e0a610bb7f 100644
--- a/chrome/browser/ssl/ssl_blocking_page.h
+++ b/chrome/browser/ssl/ssl_blocking_page.h
@@ -11,6 +11,7 @@
#include "base/callback.h"
#include "base/strings/string16.h"
#include "base/time/time.h"
+#include "chrome/browser/history/history_service.h"
#include "content/public/browser/interstitial_page_delegate.h"
#include "net/ssl/ssl_info.h"
#include "url/gurl.h"
@@ -60,6 +61,12 @@ class SSLBlockingPage : public content::InterstitialPageDelegate {
void NotifyDenyCertificate();
void NotifyAllowCertificate();
+ // Used to query the HistoryService to see if the URL is in history. For UMA.
+ void OnGotHistoryCount(HistoryService::Handle handle,
+ bool success,
+ int num_visits,
+ base::Time first_visit);
+
base::Callback<void(bool)> callback_;
content::WebContents* web_contents_;
@@ -74,6 +81,10 @@ class SSLBlockingPage : public content::InterstitialPageDelegate {
content::InterstitialPage* interstitial_page_; // Owns us.
// Is the hostname for an internal network?
bool internal_;
+ // How many times is this same URL in history?
+ int num_visits_;
+ // Used for getting num_visits_.
+ CancelableRequestConsumer request_consumer_;
// For the FieldTrial: this contains the name of the condition.
std::string trialCondition_;
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698