Issue 22350002: Speed up test importing by doing all the regex matching in a single pass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22350002: Speed up test importing by doing all the regex matching in a single pass. (Closed)

Created:
7 years, 4 months ago by Dirk Pranke

Modified:
7 years, 4 months ago

Reviewers:
ojan

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Speed up test importing by doing all the regex matching in a single pass. This gives something like a 15x speedup over compiling and matching one property at a time and doing multiple passes over the file. R=ojan@chromium.org BUG=268702 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155647

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -16 lines)			Patch
	M	Tools/Scripts/webkitpy/w3c/test_converter.py	View		3 chunks	+21 lines, -16 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/22350002/1

7 years, 4 months ago (2013-08-07 00:44:25 UTC) #3

Message was sent while issue was closed.

Change committed as 155647