Issue 22340006: Show notifications for Network Config errors

Issue 22340006: Show notifications for Network Config errors (Closed)

Created:
7 years, 4 months ago by stevenjb

Modified:
7 years, 4 months ago

Reviewers:
gauravsh, pneubeck (no reviews)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Show notifications for Network Config errors Follow up to https://codereview.chromium.org/21046008/ to: * Treat invalid 'share' parameter as a configuration failure * Show error notifications for configuration failures * Eliminate NetworkStateNotifier::NetworkConnectionStateChanged which watched for connect failures triggered by NetworkLibrary connection attempts. This is now redundant and could result in duplicate notifications (one would replace the other). BUG=270936 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216824

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : Rebase #

Patch Set 6 : Improve comments #

Patch Set 7 : Elim unused SetConnectingNetwork and fix tests #

Total comments: 1

Patch Set 8 : Rebase + move comment #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+259 lines, -201 lines)			Patch
M	ash/ash_chromeos_strings.grdp	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/system/chromeos/network/network_connect.cc	View	1 2 3 4 5	10 chunks	+63 lines, -21 lines	0 comments	Download
M	ash/system/chromeos/network/network_icon.cc	View	1 2 3 4 5 6	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/system/chromeos/network/network_state_notifier.h	View	1 2 3 4 5	3 chunks	+15 lines, -14 lines	0 comments	Download
M	ash/system/chromeos/network/network_state_notifier.cc	View	1 2 3 4 5	6 chunks	+48 lines, -61 lines	0 comments	Download
M	ash/system/chromeos/network/network_state_notifier_unittest.cc	View	1 2 3 4 5 6	4 chunks	+16 lines, -25 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.cc	View	1 2 3 4 5 6	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/options/network_connect.cc	View	1 2 3	1 chunk	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/options/wifi_config_view.h	View	1 2	3 chunks	+11 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/options/wifi_config_view.cc	View	1 2	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chromeos/dbus/shill_service_client_stub.cc	View	1 2 3 4 5 6	3 chunks	+21 lines, -2 lines	0 comments	Download
M	chromeos/network/network_connection_handler.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chromeos/network/network_connection_handler.cc	View	1 2 3	6 chunks	+46 lines, -32 lines	0 comments	Download
M	chromeos/network/network_handler_callbacks.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chromeos/network/network_state.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/network/network_state.cc	View	1 2 3 4 5 6 7	2 chunks	+8 lines, -1 line	0 comments	Download
M	chromeos/network/network_state_handler.h	View	1 2 3 4 5 6	2 chunks	+0 lines, -10 lines	0 comments	Download
M	chromeos/network/network_state_handler.cc	View	1 2 3 4 5 6	2 chunks	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

stevenjb

PTAL when you can. I'd like to get this in by Monday if possible, especially ...

7 years, 4 months ago (2013-08-09 17:54:04 UTC) #2

gauravsh

lgtm https://codereview.chromium.org/22340006/diff/18001/chromeos/network/network_state.cc File chromeos/network/network_state.cc (right): https://codereview.chromium.org/22340006/diff/18001/chromeos/network/network_state.cc#newcode114 chromeos/network/network_state.cc:114: // Shill uses "Unknown" to indicate an unset ...

7 years, 4 months ago (2013-08-09 21:46:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/22340006/25001

7 years, 4 months ago (2013-08-10 00:40:33 UTC) #4

Message was sent while issue was closed.

Change committed as 216824

Expand Messages | Collapse Messages