Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chromeos/network/network_state_handler.cc

Issue 22340006: Show notifications for Network Config errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + move comment Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_state_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_state_handler.cc
diff --git a/chromeos/network/network_state_handler.cc b/chromeos/network/network_state_handler.cc
index ab3d46448691d0e6c9066e278c319035587d4f33..04b6e2839fa9e84f755284dc7bef14fbb1421307 100644
--- a/chromeos/network/network_state_handler.cc
+++ b/chromeos/network/network_state_handler.cc
@@ -368,16 +368,6 @@ void NetworkStateHandler::RequestUpdateForAllNetworks() {
}
}
-void NetworkStateHandler::SetConnectingNetwork(
- const std::string& service_path) {
- connecting_network_ = service_path;
- const NetworkState* network = GetNetworkState(service_path);
- if (network)
- NET_LOG_EVENT("SetConnectingNetwork", GetManagedStateLogName(network));
- else
- NET_LOG_ERROR("SetConnectingNetwork to unknown network", service_path);
-}
-
void NetworkStateHandler::SetCheckPortalList(
const std::string& check_portal_list) {
NET_LOG_EVENT("SetCheckPortalList", check_portal_list);
@@ -703,16 +693,6 @@ void NetworkStateHandler::NetworkPropertiesUpdated(
const NetworkState* network) {
FOR_EACH_OBSERVER(NetworkStateHandlerObserver, observers_,
NetworkPropertiesUpdated(network));
- // If |connecting_network_| transitions to a non-idle, non-connecting state,
- // clear it *after* signaling observers.
- if (network->path() == connecting_network_ &&
- !network->IsConnectingState() &&
- network->connection_state() != flimflam::kStateIdle) {
- connecting_network_.clear();
- NET_LOG_EVENT("ClearConnectingNetwork", base::StringPrintf(
- "%s:%s", GetManagedStateLogName(network).c_str(),
- network->connection_state().c_str()));
- }
}
void NetworkStateHandler::ScanCompleted(const std::string& type) {
« no previous file with comments | « chromeos/network/network_state_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698