Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22339010: Docserver api dependencies no longer crash cron (Closed)

Created:
7 years, 4 months ago by jshumway
Modified:
7 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Docserver api dependencies no longer crash cron The code that generates the dependency rows for the intro tables now follows transitive dependencies, attempting to add items to either permssions or manifest. If a 'None' dependency is found eventually, it isn't listed. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215974

Patch Set 1 #

Total comments: 2

Patch Set 2 : yaml bump #

Patch Set 3 : readd failure case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/common/extensions/docs/server2/api_data_source.py View 1 2 1 chunk +11 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jshumway
7 years, 4 months ago (2013-08-06 19:11:09 UTC) #1
not at google - send to devlin
lgtm, thanks for doing this so quickly. https://codereview.chromium.org/22339010/diff/1/chrome/common/extensions/docs/server2/api_data_source.py File chrome/common/extensions/docs/server2/api_data_source.py (right): https://codereview.chromium.org/22339010/diff/1/chrome/common/extensions/docs/server2/api_data_source.py#newcode232 chrome/common/extensions/docs/server2/api_data_source.py:232: elif context ...
7 years, 4 months ago (2013-08-06 20:25:58 UTC) #2
not at google - send to devlin
On 2013/08/06 20:25:58, kalman wrote: > lgtm, thanks for doing this so quickly. > > ...
7 years, 4 months ago (2013-08-06 20:26:10 UTC) #3
not at google - send to devlin
bump app.yaml version too plz
7 years, 4 months ago (2013-08-06 20:27:40 UTC) #4
jshumway
https://codereview.chromium.org/22339010/diff/1/chrome/common/extensions/docs/server2/api_data_source.py File chrome/common/extensions/docs/server2/api_data_source.py (right): https://codereview.chromium.org/22339010/diff/1/chrome/common/extensions/docs/server2/api_data_source.py#newcode232 chrome/common/extensions/docs/server2/api_data_source.py:232: elif context is not None: On 2013/08/06 20:25:58, kalman ...
7 years, 4 months ago (2013-08-06 21:01:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaredshumway94@gmail.com/22339010/9001
7 years, 4 months ago (2013-08-06 21:02:53 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 21:04:23 UTC) #7
Message was sent while issue was closed. 
Change committed as 215974

Powered by Google App Engine
This is Rietveld 408576698