Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4723)

Unified Diff: chrome/common/extensions/docs/server2/api_data_source.py

Issue 22339010: Docserver api dependencies no longer crash cron (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: readd failure case Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/docs/server2/app.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/server2/api_data_source.py
diff --git a/chrome/common/extensions/docs/server2/api_data_source.py b/chrome/common/extensions/docs/server2/api_data_source.py
index 6211cdb4c7581749d3a066d36a892d1064c1d339..0301e30cbc8e3e120f3db0970f9edb819e187eea 100644
--- a/chrome/common/extensions/docs/server2/api_data_source.py
+++ b/chrome/common/extensions/docs/server2/api_data_source.py
@@ -223,15 +223,23 @@ class _JSCModel(object):
permissions_content = []
manifest_content = []
- for dependency in dependencies:
+ def categorize_dependency(dependency):
context, name = dependency.split(':', 1)
if context == 'permission':
permissions_content.append(make_code_node('"%s"' % name))
elif context == 'manifest':
manifest_content.append(make_code_node('"%s": {...}' % name))
+ elif context == 'api':
+ transitive_dependencies = (
+ self._api_features.get(context, {}).get('dependencies', []))
+ for transitive_dependency in transitive_dependencies:
+ categorize_dependency(transitive_dependency)
else:
- raise ValueError('Unrecognized dependency for %s: %s'
- % (self._namespace.name, context))
+ raise ValueError('Unrecognized dependency for %s: %s' % (
+ self._namespace.name, context))
+
+ for dependency in dependencies:
+ categorize_dependency(dependency)
dependency_rows = []
if permissions_content:
« no previous file with comments | « no previous file | chrome/common/extensions/docs/server2/app.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698