Issue 22280002: use custom_element pkg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22280002: use custom_element pkg (Closed)

Created:
7 years, 4 months ago by Jennifer Messerly

Modified:
7 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/web-ui.git@master

Visibility:
Public.

More Reviews

Description

use custom_element pkg an alternate approach to noSuchMethod... WDYT? also workaround the Map issue someone reported R=sigmund@google.com Committed: https://github.com/dart-lang/web-ui/commit/7cfc4f1

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
M	lib/observe/map.dart	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download
M	lib/web_ui.dart	View	1	3 chunks	+2 lines, -5 lines	0 comments	Download
M	pubspec.yaml	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm it's worth a try. Seems like yes, the warning is there, but only when ...

7 years, 4 months ago (2013-08-05 22:02:06 UTC) #2

Jennifer Messerly

Committed patchset #3 manually as r7cfc4f1 (presubmit successful).

7 years, 4 months ago (2013-08-06 00:03:08 UTC) #3

Jennifer Messerly

7 years, 4 months ago (2013-08-06 16:35:33 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/22280002/diff/2001/lib/observe/map.dart
File lib/observe/map.dart (right):

https://codereview.chromium.org/22280002/diff/2001/lib/observe/map.dart#newco...
lib/observe/map.dart:46: factory ObservableMap.from(Map/*<K, V>*/ other,
{MapFactory/*<K, V>*/ createMap}) {
On 2013/08/05 22:02:06, Siggi Cherem (dart-lang) wrote:
> 80 col

Done.

Expand Messages | Collapse Messages