chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java - Issue 2226733004: [Android] Add an about flag for Download Manager UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 2226733004: [Android] Add an about flag for Download Manager UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enable_by_default -> disable_by_default Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

index 0516138f48a22976ad81a202db1c984c230e5d5c..6eee512382f6dd416dc79436df859b6b1976ef5d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

@@ -8,10 +8,9 @@ import android.text.TextUtils;

import android.view.Menu;

import android.view.MenuItem;

-import org.chromium.base.CommandLine;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

-import org.chromium.chrome.browser.ChromeSwitches;

+import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.bookmarks.BookmarkBridge;

@@ -107,8 +106,8 @@ public class AppMenuPropertiesDelegate {

updateBookmarkMenuItem(bookmarkMenuItem, currentTab);

}

- menu.findItem(R.id.downloads_menu_id).setVisible(

- CommandLine.getInstance().hasSwitch(ChromeSwitches.ENABLE_DOWNLOAD_MANAGER_UI));

+ menu.findItem(R.id.downloads_menu_id)

+ .setVisible(ChromeFeatureList.isEnabled("DownloadsUi"));

menu.findItem(R.id.update_menu_id).setVisible(

UpdateMenuItemHelper.getInstance().shouldShowMenuItem(mActivity));