chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 2226733004: [Android] Add an about flag for Download Manager UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2226733004: [Android] Add an about flag for Download Manager UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enable_by_default -> disable_by_default Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index 1a26272263bde66a1c71615c4594117bce4d7332..dfa556255b970d43a8dae5099930d8564fd59bab 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -59,7 +59,7 @@ import org.chromium.chrome.browser.customtabs.CustomTabActivity;

import org.chromium.chrome.browser.customtabs.CustomTabIntentDataProvider;

import org.chromium.chrome.browser.device.DeviceClassManager;

import org.chromium.chrome.browser.document.ChromeLauncherActivity;

-import org.chromium.chrome.browser.download.DownloadActivity;

+import org.chromium.chrome.browser.download.DownloadUtils;

import org.chromium.chrome.browser.firstrun.FirstRunActivity;

import org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer;

import org.chromium.chrome.browser.firstrun.FirstRunSignInProcessor;

@@ -1099,11 +1099,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode

getToolbarManager().setUrlBarFocus(true);

}

} else if (id == R.id.downloads_menu_id) {

- if (isTablet()) {

- currentTab.loadUrl(new LoadUrlParams(UrlConstants.DOWNLOADS_URL));

- } else {

- DownloadActivity.launch(this);

- }

+ DownloadUtils.showDownloadManager(this, currentTab);

} else if (id == R.id.open_recently_closed_tab) {

TabModel currentModel = mTabModelSelectorImpl.getCurrentModel();

if (!currentModel.isIncognito()) currentModel.openMostRecentlyClosedTab();