Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 22262004: Drop struct BootStat and all usage (boot stats are now sent from chromeos code). (Closed)

Created:
7 years, 4 months ago by Alexander Alekseev
Modified:
7 years, 4 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Drop struct BootStat and all usage (boot stats are now sent from chromeos code). BUG=141757 As far as I see, after migrating BootTime.Total BootTime.Firmware BootTime.Kernel BootTime.System BootTime.Chrome to chromeos, struct chromeos::BootTimesLoader::BootTimes becomes empty. So I've dropped it completely and all references to it. Probably class BootTimesLoader should also be renamed as it doesn't load any times anymore, but instead reports time marks. Please review. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -244 lines) Patch
M chrome/browser/chromeos/boot_times_loader.h View 2 chunks +0 lines, -34 lines 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 2 chunks +0 lines, -156 lines 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M chrome/browser/resources/chromeos/login/version.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Alexander Alekseev
7 years, 4 months ago (2013-08-08 17:06:36 UTC) #1
Alexander Alekseev
Please review.
7 years, 4 months ago (2013-08-08 17:06:55 UTC) #2
Alexander Alekseev
Chromeos patch here: https://gerrit.chromium.org/gerrit/#/c/63603/
7 years, 4 months ago (2013-08-08 17:07:55 UTC) #3
DaveMoore
lgtm
7 years, 4 months ago (2013-08-08 18:46:54 UTC) #4
Nikita (slow)
lgtm
7 years, 4 months ago (2013-08-09 15:53:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/22262004/1
7 years, 4 months ago (2013-08-09 15:54:08 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=185897
7 years, 4 months ago (2013-08-09 23:28:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/22262004/1
7 years, 4 months ago (2013-08-12 10:50:32 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 16:17:30 UTC) #9
Message was sent while issue was closed.
Change committed as 217006

Powered by Google App Engine
This is Rietveld 408576698