Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: chrome/browser/chromeos/boot_times_loader.h

Issue 22262004: Drop struct BootStat and all usage (boot stats are now sent from chromeos code). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/boot_times_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/boot_times_loader.h
diff --git a/chrome/browser/chromeos/boot_times_loader.h b/chrome/browser/chromeos/boot_times_loader.h
index 2312a576f93630b0940cabeb287a39b6959e0f4b..2abc1649873bdeb66b6e964577c5a2875a81f2c1 100644
--- a/chrome/browser/chromeos/boot_times_loader.h
+++ b/chrome/browser/chromeos/boot_times_loader.h
@@ -34,38 +34,8 @@ class BootTimesLoader : public content::NotificationObserver {
BootTimesLoader();
virtual ~BootTimesLoader();
- // All fields are 0.0 if they couldn't be found.
- typedef struct BootTimes {
- double firmware; // Time from power button to kernel being loaded.
- double pre_startup; // Time from kernel to system code being called.
- double x_started; // Time X server is ready to be connected to.
- double chrome_exec; // Time session manager executed Chrome.
- double chrome_main; // Time chrome's main() was called.
- double login_prompt_ready; // Time login (or OOB) panel is displayed.
- double system; // Time system took to start chrome.
- double chrome; // Time chrome took to display login panel.
- double total; // Time from power button to login panel.
-
- BootTimes() : firmware(0),
- pre_startup(0),
- x_started(0),
- chrome_exec(0),
- chrome_main(0),
- login_prompt_ready(0),
- system(0),
- chrome(0),
- total(0) {}
- } BootTimes;
-
static BootTimesLoader* Get();
- typedef base::Callback<void(const BootTimes&)> GetBootTimesCallback;
-
- // Asynchronously requests the info.
- CancelableTaskTracker::TaskId GetBootTimes(
- const GetBootTimesCallback& callback,
- CancelableTaskTracker* tracker);
-
// Add a time marker for login. A timeline will be dumped to
// /tmp/login-times-sent after login is done. If |send_to_uma| is true
// the time between this marker and the last will be sent to UMA with
@@ -113,10 +83,6 @@ class BootTimesLoader : public content::NotificationObserver {
public:
Backend() {}
- void GetBootTimesAndRunCallback(
- const CancelableTaskTracker::IsCanceledCallback& is_canceled_cb,
- const GetBootTimesCallback& callback);
-
private:
friend class base::RefCountedThreadSafe<Backend>;
« no previous file with comments | « no previous file | chrome/browser/chromeos/boot_times_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698