Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 22209002: Added ctm matrix to GPU path (Closed)

Created:
7 years, 4 months ago by sugoi1
Modified:
7 years, 4 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Added ctm matrix to GPU path There should be no changes in behavior caused by this cl, it just adds the ctm matrix to filterImageGPU so that it may be used for scaling on all platforms when it is implemented on the blink side. BUG= Committed: http://code.google.com/p/skia/source/detail?r=10536

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed dummy matrixwq #

Patch Set 3 : Removed dummy matrix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -46 lines) Patch
M include/core/SkImageFilter.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkImageFilterUtils.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/effects/SkBicubicImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkBlurImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkDisplacementMapEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/effects/SkXfermodeImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkImageFilterUtils.cpp View 1 1 chunk +4 lines, -6 lines 0 comments Download
M src/effects/SkBicubicImageFilter.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sugoi1
7 years, 4 months ago (2013-08-05 15:00:57 UTC) #1
Stephen White
https://codereview.chromium.org/22209002/diff/1/src/core/SkImageFilterUtils.cpp File src/core/SkImageFilterUtils.cpp (left): https://codereview.chromium.org/22209002/diff/1/src/core/SkImageFilterUtils.cpp#oldcode34 src/core/SkImageFilterUtils.cpp:34: if (filter->filterImage(proxy, src, matrix, result, offset)) { We should ...
7 years, 4 months ago (2013-08-05 15:19:11 UTC) #2
sugoi1
https://codereview.chromium.org/22209002/diff/1/src/core/SkImageFilterUtils.cpp File src/core/SkImageFilterUtils.cpp (left): https://codereview.chromium.org/22209002/diff/1/src/core/SkImageFilterUtils.cpp#oldcode34 src/core/SkImageFilterUtils.cpp:34: if (filter->filterImage(proxy, src, matrix, result, offset)) { On 2013/08/05 ...
7 years, 4 months ago (2013-08-05 15:46:36 UTC) #3
Stephen White
LGTM
7 years, 4 months ago (2013-08-05 15:48:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/22209002/8001
7 years, 4 months ago (2013-08-05 16:45:51 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-05 16:53:55 UTC) #6
Message was sent while issue was closed.
Change committed as 10536

Powered by Google App Engine
This is Rietveld 408576698