extensions/common/permissions/api_permission_set.cc - Issue 221353003: Make unknown extension subpermissions warnings instead of errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/api_permission_set.cc

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/permissions/api_permission_set.cc

diff --git a/extensions/common/permissions/api_permission_set.cc b/extensions/common/permissions/api_permission_set.cc

index fbbfdc028dc47f6746f64e6004f6bc144209467b..d21ab439dea801adbc71857552e72ff23e562839 100644

--- a/extensions/common/permissions/api_permission_set.cc

+++ b/extensions/common/permissions/api_permission_set.cc

@@ -42,7 +42,8 @@ bool CreateAPIPermission(

}

std::string error_details;

- if (!permission->FromValue(permission_value, &error_details)) {

+ if (!permission->FromValue(permission_value, &error_details,

+ unhandled_permissions)) {

if (error) {

if (error_details.empty()) {

*error = ErrorUtils::FormatErrorMessageUTF16(