Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: extensions/browser/extension_prefs_factory.cc

Issue 220353002: Remove //chrome dependency from ExtensionPrefs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits, pull out ExtensionPrefsObserver Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_prefs_factory.cc
diff --git a/extensions/browser/extension_prefs_factory.cc b/extensions/browser/extension_prefs_factory.cc
index 4f59a6232501caee832bb2f7266404b477c37fe0..cb47c8fc70476d77d9b4901f43c24f4c217b313f 100644
--- a/extensions/browser/extension_prefs_factory.cc
+++ b/extensions/browser/extension_prefs_factory.cc
@@ -44,13 +44,15 @@ ExtensionPrefsFactory::~ExtensionPrefsFactory() {
KeyedService* ExtensionPrefsFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
ExtensionsBrowserClient* client = ExtensionsBrowserClient::Get();
+ std::vector<ExtensionPrefsObserver*> prefs_observers;
+ client->GetAdditionalExtensionPrefsObservers(context, &prefs_observers);
Yoyo Zhou 2014/04/02 01:40:33 Why not call this GetEarlyExtensionPrefsObservers
Ken Rockot(use gerrit already) 2014/04/02 03:53:01 SGTM - Done.
return ExtensionPrefs::Create(
client->GetPrefServiceForContext(context),
context->GetPath().AppendASCII(extensions::kInstallDirectoryName),
ExtensionPrefValueMapFactory::GetForBrowserContext(context),
client->CreateAppSorting().Pass(),
- client->AreExtensionsDisabled(
- *CommandLine::ForCurrentProcess(), context));
+ client->AreExtensionsDisabled(*CommandLine::ForCurrentProcess(), context),
+ prefs_observers);
}
content::BrowserContext* ExtensionPrefsFactory::GetBrowserContextToUse(

Powered by Google App Engine
This is Rietveld 408576698