Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: extensions/browser/extension_prefs_factory.cc

Issue 220353002: Remove //chrome dependency from ExtensionPrefs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits, pull out ExtensionPrefsObserver Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/prefs/pref_service.h" 6 #include "base/prefs/pref_service.h"
7 #include "components/keyed_service/content/browser_context_dependency_manager.h" 7 #include "components/keyed_service/content/browser_context_dependency_manager.h"
8 #include "content/public/browser/browser_context.h" 8 #include "content/public/browser/browser_context.h"
9 #include "extensions/browser/extension_pref_value_map.h" 9 #include "extensions/browser/extension_pref_value_map.h"
10 #include "extensions/browser/extension_pref_value_map_factory.h" 10 #include "extensions/browser/extension_pref_value_map_factory.h"
(...skipping 26 matching lines...) Expand all
37 "ExtensionPrefs", 37 "ExtensionPrefs",
38 BrowserContextDependencyManager::GetInstance()) { 38 BrowserContextDependencyManager::GetInstance()) {
39 } 39 }
40 40
41 ExtensionPrefsFactory::~ExtensionPrefsFactory() { 41 ExtensionPrefsFactory::~ExtensionPrefsFactory() {
42 } 42 }
43 43
44 KeyedService* ExtensionPrefsFactory::BuildServiceInstanceFor( 44 KeyedService* ExtensionPrefsFactory::BuildServiceInstanceFor(
45 content::BrowserContext* context) const { 45 content::BrowserContext* context) const {
46 ExtensionsBrowserClient* client = ExtensionsBrowserClient::Get(); 46 ExtensionsBrowserClient* client = ExtensionsBrowserClient::Get();
47 std::vector<ExtensionPrefsObserver*> prefs_observers;
48 client->GetAdditionalExtensionPrefsObservers(context, &prefs_observers);
Yoyo Zhou 2014/04/02 01:40:33 Why not call this GetEarlyExtensionPrefsObservers
Ken Rockot(use gerrit already) 2014/04/02 03:53:01 SGTM - Done.
47 return ExtensionPrefs::Create( 49 return ExtensionPrefs::Create(
48 client->GetPrefServiceForContext(context), 50 client->GetPrefServiceForContext(context),
49 context->GetPath().AppendASCII(extensions::kInstallDirectoryName), 51 context->GetPath().AppendASCII(extensions::kInstallDirectoryName),
50 ExtensionPrefValueMapFactory::GetForBrowserContext(context), 52 ExtensionPrefValueMapFactory::GetForBrowserContext(context),
51 client->CreateAppSorting().Pass(), 53 client->CreateAppSorting().Pass(),
52 client->AreExtensionsDisabled( 54 client->AreExtensionsDisabled(*CommandLine::ForCurrentProcess(), context),
53 *CommandLine::ForCurrentProcess(), context)); 55 prefs_observers);
54 } 56 }
55 57
56 content::BrowserContext* ExtensionPrefsFactory::GetBrowserContextToUse( 58 content::BrowserContext* ExtensionPrefsFactory::GetBrowserContextToUse(
57 content::BrowserContext* context) const { 59 content::BrowserContext* context) const {
58 return ExtensionsBrowserClient::Get()->GetOriginalContext(context); 60 return ExtensionsBrowserClient::Get()->GetOriginalContext(context);
59 } 61 }
60 62
61 } // namespace extensions 63 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698