Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2199713002: Refactoring: Make member variables in Resource private (Closed)

Created:
4 years, 4 months ago by hajimehoshi
Modified:
4 years, 4 months ago
Reviewers:
hiroshige, Mike West
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring: Make member variables in Resource private This CL moves some member variables in Resource class from protected to private to improve code health. BUG=n/a TEST=webkit_unit_tests Committed: https://crrev.com/33e8546b6e54b2a38d9baa327f45238cf6d64c28 Cr-Commit-Position: refs/heads/master@{#408943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
M third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 4 chunks +13 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
hajimehoshi
PTAL
4 years, 4 months ago (2016-08-01 08:24:23 UTC) #2
Mike West
LGTM.
4 years, 4 months ago (2016-08-01 11:38:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199713002/1
4 years, 4 months ago (2016-08-01 11:46:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 11:49:29 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 11:51:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33e8546b6e54b2a38d9baa327f45238cf6d64c28
Cr-Commit-Position: refs/heads/master@{#408943}

Powered by Google App Engine
This is Rietveld 408576698