Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 2199713002: Refactoring: Make member variables in Resource private (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 virtual void destroyDecodedDataIfPossible() { } 284 virtual void destroyDecodedDataIfPossible() { }
285 285
286 virtual void markClientsAndObserversFinished(); 286 virtual void markClientsAndObserversFinished();
287 287
288 // Returns the memory dump name used for tracing. See Resource::onMemoryDump . 288 // Returns the memory dump name used for tracing. See Resource::onMemoryDump .
289 String getMemoryDumpName() const; 289 String getMemoryDumpName() const;
290 290
291 const HashCountedSet<ResourceClient*>& clients() const { return m_clients; } 291 const HashCountedSet<ResourceClient*>& clients() const { return m_clients; }
292 DataBufferingPolicy dataBufferingPolicy() const { return m_options.dataBuffe ringPolicy; } 292 DataBufferingPolicy dataBufferingPolicy() const { return m_options.dataBuffe ringPolicy; }
293 293
294 ResourceRequest m_resourceRequest; 294 void setCachePolicyBypassingCache();
295 Member<ResourceLoader> m_loader; 295 void setLoFiStateOff();
296 296
297 RefPtr<SharedBuffer> m_data; 297 RefPtr<SharedBuffer> m_data;
298 298
299 private: 299 private:
300 class ResourceCallback; 300 class ResourceCallback;
301 class CachedMetadataHandlerImpl; 301 class CachedMetadataHandlerImpl;
302 class ServiceWorkerResponseCachedMetadataHandler; 302 class ServiceWorkerResponseCachedMetadataHandler;
303 303
304 void cancelTimerFired(TimerBase*); 304 void cancelTimerFired(TimerBase*);
305 305
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 HashCountedSet<ResourceClient*> m_clients; 350 HashCountedSet<ResourceClient*> m_clients;
351 HashCountedSet<ResourceClient*> m_clientsAwaitingCallback; 351 HashCountedSet<ResourceClient*> m_clientsAwaitingCallback;
352 HashCountedSet<ResourceClient*> m_finishedClients; 352 HashCountedSet<ResourceClient*> m_finishedClients;
353 353
354 ResourceLoaderOptions m_options; 354 ResourceLoaderOptions m_options;
355 355
356 double m_responseTimestamp; 356 double m_responseTimestamp;
357 357
358 Timer<Resource> m_cancelTimer; 358 Timer<Resource> m_cancelTimer;
359 359
360 ResourceRequest m_resourceRequest;
361 Member<ResourceLoader> m_loader;
360 ResourceResponse m_response; 362 ResourceResponse m_response;
361 }; 363 };
362 364
363 class ResourceFactory { 365 class ResourceFactory {
364 STACK_ALLOCATED(); 366 STACK_ALLOCATED();
365 public: 367 public:
366 virtual Resource* create(const ResourceRequest&, const ResourceLoaderOptions &, const String&) const = 0; 368 virtual Resource* create(const ResourceRequest&, const ResourceLoaderOptions &, const String&) const = 0;
367 Resource::Type type() const { return m_type; } 369 Resource::Type type() const { return m_type; }
368 370
369 protected: 371 protected:
370 ResourceFactory(Resource::Type type) : m_type(type) { } 372 ResourceFactory(Resource::Type type) : m_type(type) { }
371 373
372 Resource::Type m_type; 374 Resource::Type m_type;
373 }; 375 };
374 376
375 #define DEFINE_RESOURCE_TYPE_CASTS(typeName) \ 377 #define DEFINE_RESOURCE_TYPE_CASTS(typeName) \
376 DEFINE_TYPE_CASTS(typeName##Resource, Resource, resource, resource->getType( ) == Resource::typeName, resource.getType() == Resource::typeName); 378 DEFINE_TYPE_CASTS(typeName##Resource, Resource, resource, resource->getType( ) == Resource::typeName, resource.getType() == Resource::typeName);
377 379
378 } // namespace blink 380 } // namespace blink
379 381
380 #endif 382 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/fetch/RawResource.cpp ('k') | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698