Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Issue 21955003: Cleanup: Use content::kAboutBlankURL instead of the raw string in contents/. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix build Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/loader/resource_dispatcher_host_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/dump_accessibility_tree_browsertest.cc
===================================================================
--- content/browser/accessibility/dump_accessibility_tree_browsertest.cc (revision 215674)
+++ content/browser/accessibility/dump_accessibility_tree_browsertest.cc (working copy)
@@ -20,6 +20,7 @@
#include "content/port/browser/render_widget_host_view_port.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_paths.h"
+#include "content/public/common/url_constants.h"
#include "content/shell/shell.h"
#include "content/test/accessibility_browser_test_utils.h"
#include "content/test/content_browser_test.h"
@@ -60,8 +61,8 @@
public:
// Utility helper that does a comment aware equality check.
// Returns array of lines from expected file which are different.
- std::vector<int> DiffLines(std::vector<std::string>& expected_lines,
- std::vector<std::string>& actual_lines) {
+ std::vector<int> DiffLines(const std::vector<std::string>& expected_lines,
+ const std::vector<std::string>& actual_lines) {
int actual_lines_count = actual_lines.size();
int expected_lines_count = expected_lines.size();
std::vector<int> diff_lines;
@@ -123,7 +124,7 @@
void DumpAccessibilityTreeTest::RunTest(
const base::FilePath::CharType* file_path) {
- NavigateToURL(shell(), GURL("about:blank"));
+ NavigateToURL(shell(), GURL(kAboutBlankURL));
// Setup test paths.
base::FilePath dir_test_data;
@@ -206,7 +207,7 @@
if (diff_index < static_cast<int>(diff_lines.size()) &&
diff_lines[diff_index] == line) {
is_diff = true;
- ++ diff_index;
+ ++diff_index;
}
printf("%1s %4d %s\n", is_diff? kSignalDiff : "", line + 1,
expected_lines[line].c_str());
« no previous file with comments | « no previous file | content/browser/loader/resource_dispatcher_host_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698