Cleanup: Use content::kAboutBlankURL instead of the raw string in contents/.

content/browser/accessibility/dump_accessibility_tree_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/accessibility/accessibility_tree_formatter.h"
 #include "content/browser/accessibility/browser_accessibility.h"
 #include "content/browser/accessibility/browser_accessibility_manager.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/port/browser/render_widget_host_view_port.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_paths.h"
+#include "content/public/common/url_constants.h"
 #include "content/shell/shell.h"
 #include "content/test/accessibility_browser_test_utils.h"
 #include "content/test/content_browser_test.h"
 #include "content/test/content_browser_test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // TODO(dmazzoni): Disabled accessibility tests on Win64. crbug.com/179717
 #if defined(OS_WIN) && defined(ARCH_CPU_X86_64)
 #define MAYBE(x) DISABLED_##x
 #else
@@ skipping 20 matching lines @@
 // 1. Load an html file from chrome/test/data/accessibility.
 // 2. Read the expectation.
 // 3. Browse to the page and serialize the platform specific tree into a human
 //    readable string.
 // 4. Perform a comparison between actual and expected and fail if they do not
 //    exactly match.
 class DumpAccessibilityTreeTest : public ContentBrowserTest {
  public:
   // Utility helper that does a comment aware equality check.
   // Returns array of lines from expected file which are different.
-  std::vector<int> DiffLines(std::vector<std::string>& expected_lines,
-                             std::vector<std::string>& actual_lines) {
+  std::vector<int> DiffLines(const std::vector<std::string>& expected_lines,
+                             const std::vector<std::string>& actual_lines) {
     int actual_lines_count = actual_lines.size();
     int expected_lines_count = expected_lines.size();
     std::vector<int> diff_lines;
     int i = 0, j = 0;
     while (i < actual_lines_count && j < expected_lines_count) {
       if (expected_lines[j].size() == 0 ||
           expected_lines[j][0] == kCommentToken) {
         // Skip comment lines and blank lines in expected output.
         ++j;
         continue;
@@ skipping 41 matching lines @@
                                   Filter::DENY));
       }
     }
   }
 
   void RunTest(const base::FilePath::CharType* file_path);
 };
 
 void DumpAccessibilityTreeTest::RunTest(
     const base::FilePath::CharType* file_path) {
-  NavigateToURL(shell(), GURL("about:blank"));
+  NavigateToURL(shell(), GURL(kAboutBlankURL));
 
   // Setup test paths.
   base::FilePath dir_test_data;
   ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &dir_test_data));
   base::FilePath test_path(
       dir_test_data.Append(FILE_PATH_LITERAL("accessibility")));
   ASSERT_TRUE(base::PathExists(test_path))
       << test_path.LossyDisplayName();
 
   base::FilePath html_file = test_path.Append(base::FilePath(file_path));
@@ skipping 62 matching lines @@
     // Mark the expected lines which did not match actual output with a *.
     printf("* Line Expected\n");
     printf("- ---- --------\n");
     for (int line = 0, diff_index = 0;
          line < static_cast<int>(expected_lines.size());
          ++line) {
       bool is_diff = false;
       if (diff_index < static_cast<int>(diff_lines.size()) &&
           diff_lines[diff_index] == line) {
         is_diff = true;
-        ++ diff_index;
+        ++diff_index;
       }
       printf("%1s %4d %s\n", is_diff? kSignalDiff : "", line + 1,
              expected_lines[line].c_str());
     }
     printf("\nActual\n");
     printf("------\n");
     printf("%s\n", actual_contents.c_str());
   }
 
   if (!base::PathExists(expected_file)) {
@@ skipping 226 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityUl) {
   RunTest(FILE_PATH_LITERAL("ul.html"));
 }
 
 IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityWbr) {
   RunTest(FILE_PATH_LITERAL("wbr.html"));
 }
 
 }  // namespace content