Chromium Code Reviews| Index: chrome_frame/urlmon_moniker.cc |
| diff --git a/chrome_frame/urlmon_moniker.cc b/chrome_frame/urlmon_moniker.cc |
| index d2d5b117ce030f08065ab26f7ff2402090b6dbe7..432dd92a2483697c7758f93e9f9bfe28b330de06 100644 |
| --- a/chrome_frame/urlmon_moniker.cc |
| +++ b/chrome_frame/urlmon_moniker.cc |
| @@ -243,6 +243,7 @@ HRESULT MonikerPatch::BindToStorage(IMoniker_BindToStorage_Fn original, |
| CComObject<BSCBStorageBind>* callback = NULL; |
| if (ShouldWrapCallback(me, iid, bind_ctx)) { |
| hr = CComObject<BSCBStorageBind>::CreateInstance(&callback); |
| + DCHECK(SUCCEEDED(hr)); |
|
tommi (sloooow) - chröme
2013/08/04 12:43:12
I think this is equivalent to checking the return
etienneb
2013/08/05 13:56:26
I that case, why assign it to 'hr'?
The linter com
tommi (sloooow) - chröme
2013/08/05 15:10:54
Keeping the DCHECK is ok with me, I just don't thi
|
| auto_release_callback = callback; |
| DCHECK_EQ(callback->m_dwRef, 1); |
| hr = callback->Initialize(me, bind_ctx); |