Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: chrome_frame/urlmon_bind_status_callback.cc

Issue 21948002: Add missing DCHECK to validate HR. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix missing check to hr Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome_frame/urlmon_moniker.cc » ('j') | chrome_frame/urlmon_moniker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/urlmon_bind_status_callback.cc
diff --git a/chrome_frame/urlmon_bind_status_callback.cc b/chrome_frame/urlmon_bind_status_callback.cc
index 006e20e923123dc860add889ae9aabaafb974256..bfaced7ff8f38163e6f73e31198b59407c428299 100644
--- a/chrome_frame/urlmon_bind_status_callback.cc
+++ b/chrome_frame/urlmon_bind_status_callback.cc
@@ -320,6 +320,8 @@ STDMETHODIMP BSCBStorageBind::OnStopBinding(HRESULT hresult, LPCWSTR error) {
ExceptionBarrier barrier;
HRESULT hr = MayPlayBack(BSCF_LASTDATANOTIFICATION);
+ if (hr != S_OK)
robertshield 2013/08/02 18:35:42 FAILED(hr)
tommi (sloooow) - chröme 2013/08/04 12:43:12 No chance of S_FALSE?
etienneb 2013/08/05 13:56:26 I don't think S_FALSE can be here. At some place,
+ return hr;
hr = CallbackImpl::OnStopBinding(hresult, error);
ReleaseBind();
return hr;
« no previous file with comments | « no previous file | chrome_frame/urlmon_moniker.cc » ('j') | chrome_frame/urlmon_moniker.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698