Issue 21931002: ARM Skia NEON patches - 18 - Preparation work for BitmapProcState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21931002: ARM Skia NEON patches - 18 - Preparation work for BitmapProcState (Closed)

Created:
7 years, 4 months ago by kevin.petit.not.used.account

Modified:
7 years, 3 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

ARM Skia NEON patches - 18 - Preparation work for BitmapProcState BitmapProcState: clean a little and get rid of some asm replacing the apparently stupid dx+dx+dx leads to more instructions being generated. Signed-off-by: Kévin PETIT <kevin.petit@arm.com>; BitmapProcState: move code common to C and NEON to a separate header Signed-off-by: Kévin PETIT <kevin.petit@arm.com>; BUG= Committed: http://code.google.com/p/skia/source/detail?r=11109

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -93 lines)			Patch
M	src/core/SkBitmapProcState_matrixProcs.cpp	View	2 chunks	+1 line, -36 lines	0 comments	Download
A	src/core/SkBitmapProcState_utils.h	View	1 chunk	+40 lines, -0 lines	0 comments	Download
M	src/opts/SkBitmapProcState_matrixProcs_neon.cpp	View	3 chunks	+33 lines, -57 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevin.petit.not.used.account

ping. This is currently preventing me from uploading a big refactoring of the BitmapProcState NEON ...

7 years, 3 months ago (2013-09-04 17:05:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit.arm@gmail.com/21931002/1

7 years, 3 months ago (2013-09-05 10:07:02 UTC) #4

Message was sent while issue was closed.

Change committed as 11109

Expand Messages | Collapse Messages