Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: src/core/SkBitmapProcState_matrixProcs.cpp

Issue 21931002: ARM Skia NEON patches - 18 - Preparation work for BitmapProcState (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkBitmapProcState_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkBitmapProcState_matrixProcs.cpp
diff --git a/src/core/SkBitmapProcState_matrixProcs.cpp b/src/core/SkBitmapProcState_matrixProcs.cpp
index a3d2b08665335c5f1b345589ff4e5db82ca6dc78..65178b475716c07786632b8e41268b9aa090ca3f 100644
--- a/src/core/SkBitmapProcState_matrixProcs.cpp
+++ b/src/core/SkBitmapProcState_matrixProcs.cpp
@@ -9,13 +9,7 @@
#include "SkShader.h"
#include "SkUtils.h"
#include "SkUtilsArm.h"
-
-// Helper to ensure that when we shift down, we do it w/o sign-extension
-// so the caller doesn't have to manually mask off the top 16 bits
-//
-static unsigned SK_USHIFT16(unsigned x) {
- return x >> 16;
-}
+#include "SkBitmapProcState_utils.h"
/* returns 0...(n-1) given any x (positive or negative).
@@ -36,35 +30,6 @@ static inline int sk_int_mod(int x, int n) {
return x;
}
-/*
- * The decal_ functions require that
- * 1. dx > 0
- * 2. [fx, fx+dx, fx+2dx, fx+3dx, ... fx+(count-1)dx] are all <= maxX
- *
- * In addition, we use SkFractionalInt to keep more fractional precision than
- * just SkFixed, so we will abort the decal_ call if dx is very small, since
- * the decal_ function just operates on SkFixed. If that were changed, we could
- * skip the very_small test here.
- */
-static inline bool can_truncate_to_fixed_for_decal(SkFractionalInt frX,
- SkFractionalInt frDx,
- int count, unsigned max) {
- SkFixed dx = SkFractionalIntToFixed(frDx);
-
- // if decal_ kept SkFractionalInt precision, this would just be dx <= 0
- // I just made up the 1/256. Just don't want to perceive accumulated error
- // if we truncate frDx and lose its low bits.
- if (dx <= SK_Fixed1 / 256) {
- return false;
- }
-
- // We cast to unsigned so we don't have to check for negative values, which
- // will now appear as very large positive values, and thus fail our test!
- SkFixed fx = SkFractionalIntToFixed(frX);
- return (unsigned)SkFixedFloorToInt(fx) <= max &&
- (unsigned)SkFixedFloorToInt(fx + dx * (count - 1)) < max;
-}
-
void decal_nofilter_scale(uint32_t dst[], SkFixed fx, SkFixed dx, int count);
void decal_filter_scale(uint32_t dst[], SkFixed fx, SkFixed dx, int count);
« no previous file with comments | « no previous file | src/core/SkBitmapProcState_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698