Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 21929002: Remove unused, unimplemented and no-op methods from MIMETypeRegistry. (Closed)

Created:
7 years, 4 months ago by jbroman
Modified:
7 years, 4 months ago
Reviewers:
jamesr, abarth-chromium
CC:
blink-reviews, eae+blinkwatch, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, jeez, vcarbune.chromium, danakj
Visibility:
Public.

Description

Remove unused, unimplemented and no-op methods from MIMETypeRegistry. The following methods have been removed. Unimplemented and unused: MIMETypeRegistry::getExtensionForMIMEType(const String&) MIMETypeRegistry::getMediaMIMETypesForExtension(const String&) MIMETypeRegistry::isUnsupportedTextMIMEType(const String&) MIMETypeRegistry::canShowMIMEType(const String&) MIMETypeRegistry::getUnsupportedTextMIMETypes() MIMETypeRegistry::getNormalizedMIMEType(const String&) defaultMIMEType() Trivial and unused: MIMETypeRegistry::getSupportedImageMIMETypes() MIMETypeRegistry::getSupportedImageResourceMIMETypes() MIMETypeRegistry::getSupportedImageMIMETypesForEncoding() MIMETypeRegistry::getSupportedNonImageMIMETypes() MIMETypeRegistry::getSupportedMediaMIMETypes() Trivial implementations: MIMETypeRegistry::getMediaMIMETypeForExtension(const String&) MIMETypeRegistry::isApplicationPluginMIMEType(const String&) BUG=268948 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155631

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -65 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/html/HTMLPlugInImageElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/platform/MIMETypeRegistry.h View 2 chunks +0 lines, -27 lines 0 comments Download
M Source/core/platform/chromium/MIMETypeRegistryChromium.cpp View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jbroman
It looks like we could also get rid of MIMETypeRegistry::getPreferredExtensionForMIMEType, but that's left out of ...
7 years, 4 months ago (2013-08-06 13:56:27 UTC) #1
abarth-chromium
On 2013/08/06 13:56:27, jbroman wrote: > I would, however, appreciate your thoughts on whether that ...
7 years, 4 months ago (2013-08-06 18:40:01 UTC) #2
abarth-chromium
lgtm
7 years, 4 months ago (2013-08-06 18:40:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/21929002/1
7 years, 4 months ago (2013-08-06 18:41:02 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 21:01:40 UTC) #5
Message was sent while issue was closed.
Change committed as 155631

Powered by Google App Engine
This is Rietveld 408576698