Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2192683003: Revert of Reland: Geolocation: move from content/browser to device/ (patchset #2 id:20001 of https:… (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
mcasas, Paul Stewart
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2810
Target Ref:
refs/pending/branch-heads/2810
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Geolocation: move from content/browser to device/ (patchset #2 id:20001 of https://codereview.chromium.org/2185993003/ ) Reason for revert: Build failure: FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c ..\..\device\geolocation\network_location_request.cc /Foobj\device\geolocation\device_geolocation.network_location_request.obj /Fdobj\device\geolocation\device_geolocation.cc.pdb c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): error C2220: warning treated as error - no 'object' file generated c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data Original issue's description: > Reland: Geolocation: move from content/browser to device/ > > Original CL was reverted because it broke Win Gyp Component-build > bot(s). This CL (PS2) defines the geolocation gyp component > correctly. > > Original CL description ------------------------------------------------ > Geolocation: move from content/browser to device/ > > This CL: > > - moves all of content/browser/geolocation to device/geolocation > - the public geolocation files in content/common/{browser, public} > are also relocated to device/geolocation > - the geolocation-specific unittests are compiled into > (already existing) device_unittests > - adds new fancy new device/geolocation BUILD.gn and > geolocation.gyp as well > - makes a component of geolocation (at least for gn) and that forces > adding geolocation_export.h (like other //device/ folders). > - Java Geolocation files are moved as well, and a new > geolocation_jni_registrar is added. > - classes are moved to device namespace. > > All paths and include/call sites updated, DEPS, BUILD.gn files, > gypi files etc. > > Some tricks: > - can't use BrowserThread::CurrentlyOn, etc; instead, the > task runner is cached on constructor and used for both thread > checking and PostTask()ing (a few unittest and wifi_data_provider* > needed that substitution). > - GeolocationServiceContext is moved to public/cpp so it can > be referenced from WebContentsImpl. > - MockLocationProvider.java is also moved to device/geolocation. > > BUG=612334 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > TBR=pstew@chromium.org > rationale:device/geolocation depends on dbus and this triggers > a DEPS presubmit rule -- however, this CL adds no new dependencies, > hence moving on in the interest of speed (and avoiding more rebases). > > Committed: https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7 > Cr-Commit-Position: refs/heads/master@{#408272} TBR=pstew@chromium.org,mcasas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612334, 632239 Review-Url: https://codereview.chromium.org/2188933002 Cr-Commit-Position: refs/heads/master@{#408303} (cherry picked from commit 6a5f51a5304bdcff7eea91f71be843b72c160d94) Committed: https://chromium.googlesource.com/chromium/src/+/3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+688 lines, -6941 lines) Patch
M android_webview/browser/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/aw_browser_main_parts.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/javatests/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/engine/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M blimp/engine/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/engine/app/blimp_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/feature/geolocation/blimp_location_provider.h View 3 chunks +7 lines, -7 lines 0 comments Download
M blimp/engine/feature/geolocation/blimp_location_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M blimp/engine/feature/geolocation/engine_geolocation_feature.h View 2 chunks +5 lines, -7 lines 0 comments Download
M blimp/engine/feature/geolocation/engine_geolocation_feature.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M blimp/engine/feature/geolocation/mock_blimp_location_provider_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/session/blimp_engine_session.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/android/javatests/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.h View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/geolocation/access_token_store_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/chrome_access_token_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/chrome_access_token_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chromecast/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chromecast/browser/geolocation/cast_access_token_store.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/geolocation/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/geolocation/geoposition.h View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill.gypi View 1 chunk +1 line, -7 lines 0 comments Download
M components/autofill/content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/browser/risk/fingerprint.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M components/autofill/content/browser/risk/fingerprint_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M content/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/BUILD.gn View 5 chunks +25 lines, -3 lines 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/emulation_handler.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 4 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + content/browser/geolocation/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/geolocation/empty_wifi_data_provider.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/geolocation/empty_wifi_data_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/fake_access_token_store.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/geolocation/fake_access_token_store.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/geolocation_provider_impl.h View 3 chunks +9 lines, -13 lines 0 comments Download
A + content/browser/geolocation/geolocation_provider_impl.cc View 9 chunks +19 lines, -17 lines 0 comments Download
A + content/browser/geolocation/geolocation_provider_impl_unittest.cc View 9 chunks +14 lines, -10 lines 0 comments Download
A + content/browser/geolocation/geolocation_service_context.h View 2 chunks +7 lines, -10 lines 0 comments Download
A + content/browser/geolocation/geolocation_service_context.cc View 2 chunks +3 lines, -5 lines 0 comments Download
A + content/browser/geolocation/geolocation_service_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/geolocation/geolocation_service_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/location_api_adapter_android.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/geolocation/location_api_adapter_android.cc View 4 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/geolocation/location_arbitrator.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + content/browser/geolocation/location_arbitrator_impl.h View 4 chunks +12 lines, -13 lines 0 comments Download
A + content/browser/geolocation/location_arbitrator_impl.cc View 4 chunks +8 lines, -7 lines 0 comments Download
A + content/browser/geolocation/location_arbitrator_impl_unittest.cc View 2 chunks +8 lines, -7 lines 0 comments Download
A + content/browser/geolocation/location_provider_android.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + content/browser/geolocation/location_provider_android.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/geolocation/location_provider_base.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + content/browser/geolocation/location_provider_base.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/mock_location_arbitrator.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/geolocation/mock_location_arbitrator.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/mock_location_provider.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + content/browser/geolocation/mock_location_provider.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/network_location_provider.h View 3 chunks +12 lines, -12 lines 0 comments Download
A + content/browser/geolocation/network_location_provider.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/network_location_provider_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/geolocation/network_location_request.h View 5 chunks +8 lines, -8 lines 0 comments Download
A + content/browser/geolocation/network_location_request.cc View 4 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/geolocation/wifi_data.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + content/browser/geolocation/wifi_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_chromeos.h View 2 chunks +8 lines, -16 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_chromeos.cc View 6 chunks +13 lines, -13 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_chromeos_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_common.h View 4 chunks +9 lines, -10 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_common.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_common_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_common_win.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_common_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_corewlan_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_linux.h View 2 chunks +8 lines, -9 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_linux.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_linux_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_mac.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_mac.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_manager.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_win.h View 2 chunks +8 lines, -9 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_win.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_win_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/geolocation/wifi_polling_policy.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M content/content_browser.gypi View 9 chunks +66 lines, -0 lines 0 comments Download
M content/content_common.gypi View 3 chunks +3 lines, -2 lines 0 comments Download
M content/content_jni.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 8 chunks +26 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/browser/LocationProviderAdapter.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A + content/public/browser/access_token_store.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + content/public/browser/geolocation_delegate.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + content/public/browser/geolocation_delegate.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/public/browser/geolocation_provider.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + content/public/browser/location_provider.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + content/public/common/geoposition.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + content/public/common/geoposition.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/android/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
A + content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockLocationProvider.java View 1 chunk +4 lines, -1 line 0 comments Download
M content/public/test/content_test_suite_base.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_access_token_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/test/BUILD.gn View 6 chunks +6 lines, -3 lines 0 comments Download
M device/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D device/geolocation/BUILD.gn View 1 chunk +0 lines, -200 lines 0 comments Download
D device/geolocation/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D device/geolocation/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D device/geolocation/access_token_store.h View 1 chunk +0 lines, -56 lines 0 comments Download
D device/geolocation/android/geolocation_jni_registrar.h View 1 chunk +0 lines, -24 lines 0 comments Download
D device/geolocation/android/geolocation_jni_registrar.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D device/geolocation/android/java/org/chromium/device/geolocation/LocationProviderAdapter.java View 1 chunk +0 lines, -100 lines 0 comments Download
D device/geolocation/android/java/org/chromium/device/geolocation/LocationProviderFactory.java View 1 chunk +0 lines, -212 lines 0 comments Download
D device/geolocation/android/java/org/chromium/device/geolocation/MockLocationProvider.java View 1 chunk +0 lines, -89 lines 0 comments Download
D device/geolocation/empty_wifi_data_provider.h View 1 chunk +0 lines, -32 lines 0 comments Download
D device/geolocation/empty_wifi_data_provider.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D device/geolocation/fake_access_token_store.h View 1 chunk +0 lines, -54 lines 0 comments Download
D device/geolocation/fake_access_token_store.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D device/geolocation/geolocation.gyp View 1 chunk +0 lines, -133 lines 0 comments Download
D device/geolocation/geolocation_delegate.h View 1 chunk +0 lines, -39 lines 0 comments Download
D device/geolocation/geolocation_delegate.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D device/geolocation/geolocation_export.h View 1 chunk +0 lines, -28 lines 0 comments Download
D device/geolocation/geolocation_provider.h View 1 chunk +0 lines, -71 lines 0 comments Download
D device/geolocation/geolocation_provider_impl.h View 1 chunk +0 lines, -106 lines 0 comments Download
D device/geolocation/geolocation_provider_impl.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D device/geolocation/geolocation_provider_impl_unittest.cc View 1 chunk +0 lines, -258 lines 0 comments Download
D device/geolocation/geolocation_service_context.h View 1 chunk +0 lines, -64 lines 0 comments Download
D device/geolocation/geolocation_service_context.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D device/geolocation/geolocation_service_impl.h View 1 chunk +0 lines, -84 lines 0 comments Download
D device/geolocation/geolocation_service_impl.cc View 1 chunk +0 lines, -195 lines 0 comments Download
D device/geolocation/geoposition.h View 1 chunk +0 lines, -69 lines 0 comments Download
D device/geolocation/geoposition.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D device/geolocation/location_api_adapter_android.h View 1 chunk +0 lines, -85 lines 0 comments Download
D device/geolocation/location_api_adapter_android.cc View 1 chunk +0 lines, -172 lines 0 comments Download
D device/geolocation/location_arbitrator.h View 1 chunk +0 lines, -37 lines 0 comments Download
D device/geolocation/location_arbitrator_impl.h View 1 chunk +0 lines, -129 lines 0 comments Download
D device/geolocation/location_arbitrator_impl.cc View 1 chunk +0 lines, -212 lines 0 comments Download
D device/geolocation/location_arbitrator_impl_unittest.cc View 1 chunk +0 lines, -442 lines 0 comments Download
D device/geolocation/location_provider.h View 1 chunk +0 lines, -58 lines 0 comments Download
D device/geolocation/location_provider_android.h View 1 chunk +0 lines, -38 lines 0 comments Download
D device/geolocation/location_provider_android.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D device/geolocation/location_provider_base.h View 1 chunk +0 lines, -36 lines 0 comments Download
D device/geolocation/location_provider_base.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D device/geolocation/mock_location_arbitrator.h View 1 chunk +0 lines, -37 lines 0 comments Download
D device/geolocation/mock_location_arbitrator.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D device/geolocation/mock_location_provider.h View 1 chunk +0 lines, -64 lines 0 comments Download
D device/geolocation/mock_location_provider.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D device/geolocation/network_location_provider.h View 1 chunk +0 lines, -146 lines 0 comments Download
D device/geolocation/network_location_provider.cc View 1 chunk +0 lines, -273 lines 0 comments Download
D device/geolocation/network_location_provider_unittest.cc View 1 chunk +0 lines, -559 lines 0 comments Download
D device/geolocation/network_location_request.h View 1 chunk +0 lines, -81 lines 0 comments Download
D device/geolocation/network_location_request.cc View 1 chunk +0 lines, -427 lines 0 comments Download
D device/geolocation/wifi_data.h View 1 chunk +0 lines, -54 lines 0 comments Download
D device/geolocation/wifi_data.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D device/geolocation/wifi_data_provider.h View 1 chunk +0 lines, -74 lines 0 comments Download
D device/geolocation/wifi_data_provider.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D device/geolocation/wifi_data_provider_chromeos.h View 1 chunk +0 lines, -75 lines 0 comments Download
D device/geolocation/wifi_data_provider_chromeos.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D device/geolocation/wifi_data_provider_chromeos_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D device/geolocation/wifi_data_provider_common.h View 1 chunk +0 lines, -85 lines 0 comments Download
D device/geolocation/wifi_data_provider_common.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D device/geolocation/wifi_data_provider_common_unittest.cc View 1 chunk +0 lines, -239 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tsergeant
4 years, 4 months ago (2016-07-28 05:02:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c11c360e0ea56cfaed1b0d6da18a8353a20f7b2.

Powered by Google App Engine
This is Rietveld 408576698