MacViews: Fix scrolling when clicking on the views::ScrollView scroll track

MacViews: Fix scrolling when clicking on the views::ScrollView scroll track

Currently the mouse up event is lost, resulting in the repeating timer
never resetting.

CocoaScrollBar just needs to invoke super::OnMouseReleased().

Sets up views::ScrollView for event testing, and adds a test.

BUG=632261
Committed: https://crrev.com/c2f76449767bc5a1e426bba55ae1c52aab69ff75
Cr-Commit-Position: refs/heads/master@{#409114}

[tapted, 2016-07-28 06:04:34]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 06:04:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-07-28 06:32:09]

Description was changed from

==========
MacViews: Fix scrolling when clicking on the views::ScrollView scroll track

Currently the mouse up event is lost, resulting in the repeating timer
never reseting.

CocoaScrollBar just needs to invoke super.

BUG=
==========

to

==========
MacViews: Fix scrolling when clicking on the views::ScrollView scroll track

Currently the mouse up event is lost, resulting in the repeating timer
never resetting.

CocoaScrollBar just needs to invoke super::OnMouseReleased

BUG=632261
==========

[commit-bot: I haz the power, 2016-07-28 06:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 06:36:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tapted, 2016-07-28 07:09:31]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 07:09:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 07:38:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 07:38:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tapted, 2016-07-28 09:13:09]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 09:13:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 10:27:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 10:27:36]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-07-28 11:30:54]

Description was changed from

==========
MacViews: Fix scrolling when clicking on the views::ScrollView scroll track

Currently the mouse up event is lost, resulting in the repeating timer
never resetting.

CocoaScrollBar just needs to invoke super::OnMouseReleased

BUG=632261
==========

to

==========
MacViews: Fix scrolling when clicking on the views::ScrollView scroll track

Currently the mouse up event is lost, resulting in the repeating timer
never resetting.

CocoaScrollBar just needs to invoke super::OnMouseReleased().

Sets up views::ScrollView for event testing, and adds a test.

BUG=632261
==========

[tapted, 2016-07-28 11:30:55]

tapted@chromium.org changed reviewers:
+ sky@chromium.org

[tapted, 2016-07-28 11:36:00]

Hi sky, please take a look. It's a lot of test harness for a one-line fix, but
it'll come in handy for the crazy stuff in the pipeline for scrolling with
layers (smooth scrolling, elasticity, etc.), where events will need to be
diverted to a cc::InputHandler.

Also a test api felt like too big a hammer for RepeatController..  see what you
think.

[tapted, 2016-07-29 00:07:48]

tapted@chromium.org changed reviewers:
+ sadrul@chromium.org
- sky@chromium.org

[tapted, 2016-07-29 00:07:49]

-sky
+sadrul - could you take a look? Looks like sky is OOO for a bit. Thanks!

On 2016/07/28 11:36:00, tapted wrote:
> Hi sky, please take a look. It's a lot of test harness for a one-line fix, but
> it'll come in handy for the crazy stuff in the pipeline for scrolling with
> layers (smooth scrolling, elasticity, etc.), where events will need to be
> diverted to a cc::InputHandler.
> 
> Also a test api felt like too big a hammer for RepeatController..  see what
you
> think.

[sky, 2016-08-01 22:33:34]

sky@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-08-01 22:33:35]

LGTM

https://codereview.chromium.org/2192443003/diff/60001/ui/views/controls/scrol...
File ui/views/controls/scroll_view_unittest.cc (right):

https://codereview.chromium.org/2192443003/diff/60001/ui/views/controls/scrol...
ui/views/controls/scroll_view_unittest.cc:35: return
static_cast<NativeScrollBarViews*>(
ick!

https://codereview.chromium.org/2192443003/diff/60001/ui/views/controls/scrol...
ui/views/controls/scroll_view_unittest.cc:120: const int kDefaultHeight = 100;
static on these two?

[tapted, 2016-08-02 00:05:08]

Thanks sky!

https://codereview.chromium.org/2192443003/diff/60001/ui/views/controls/scrol...
File ui/views/controls/scroll_view_unittest.cc (right):

https://codereview.chromium.org/2192443003/diff/60001/ui/views/controls/scrol...
ui/views/controls/scroll_view_unittest.cc:35: return
static_cast<NativeScrollBarViews*>(
On 2016/08/01 22:33:35, sky wrote:
> ick!

yeah.. that was an interesting journey. I guess this is http://crbug.com/93103
"Get rid of NativeScrollBar", which I think is still valid. Mac seems to be
happy with the flattened class structure, so I should be able to explore this
for other platforms soon..

https://codereview.chromium.org/2192443003/diff/60001/ui/views/controls/scrol...
ui/views/controls/scroll_view_unittest.cc:120: const int kDefaultHeight = 100;
On 2016/08/01 22:33:35, sky wrote:
> static on these two?

Done.

I'd actually flip-flopped on this a bit. When they are static, they also need a
separate definition, which didn't feel as neat. I think passing them directly to
the EXPECT macros (i.e. not part of an expression) results in the compiler
generating code that wants an address for the constant. `constexpr` didn't
change this. An enum constant would avoid it, but it also felt less neat. Enum
constants haven't really caught on in chrome, but would probably be my choice in
isolation.

Anyway, went with static :)

[tapted, 2016-08-02 00:32:15]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-08-02 00:32:16]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2192443003/#ps80001
(title: "static const")

[commit-bot: I haz the power, 2016-08-02 00:32:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 01:26:45]

Description was changed from

==========
MacViews: Fix scrolling when clicking on the views::ScrollView scroll track

Currently the mouse up event is lost, resulting in the repeating timer
never resetting.

CocoaScrollBar just needs to invoke super::OnMouseReleased().

Sets up views::ScrollView for event testing, and adds a test.

BUG=632261
==========

to

==========
MacViews: Fix scrolling when clicking on the views::ScrollView scroll track

Currently the mouse up event is lost, resulting in the repeating timer
never resetting.

CocoaScrollBar just needs to invoke super::OnMouseReleased().

Sets up views::ScrollView for event testing, and adds a test.

BUG=632261
==========

[commit-bot: I haz the power, 2016-08-02 01:26:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-02 01:28:29]

Description was changed from

==========
MacViews: Fix scrolling when clicking on the views::ScrollView scroll track

Currently the mouse up event is lost, resulting in the repeating timer
never resetting.

CocoaScrollBar just needs to invoke super::OnMouseReleased().

Sets up views::ScrollView for event testing, and adds a test.

BUG=632261
==========

to

==========
MacViews: Fix scrolling when clicking on the views::ScrollView scroll track

Currently the mouse up event is lost, resulting in the repeating timer
never resetting.

CocoaScrollBar just needs to invoke super::OnMouseReleased().

Sets up views::ScrollView for event testing, and adds a test.

BUG=632261

Committed: https://crrev.com/c2f76449767bc5a1e426bba55ae1c52aab69ff75
Cr-Commit-Position: refs/heads/master@{#409114}
==========

[commit-bot: I haz the power, 2016-08-02 01:28:30]

Patchset 5 (id:??) landed as
https://crrev.com/c2f76449767bc5a1e426bba55ae1c52aab69ff75
Cr-Commit-Position: refs/heads/master@{#409114}