Issue 21913003: Ensure that renderer-initiated pending entries can be replaced when a new

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21913003: Ensure that renderer-initiated pending entries can be replaced when a new (Closed)

Created:
7 years, 4 months ago by Charlie Reis

Modified:
7 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ensure that renderer-initiated pending entries can be replaced when a new navigation is started. We don't replace browser-initiated pending entries in didStartProvisionalLoad because either (1) they were just created for this navigation and are already correct, (2) they're for a different SiteInstance and won't be used upon commit, or (3) they're same-site (see below). Note that pending entries for same-site browser-initiated navigations can be incorrectly used for renderer-initiated navigations that interrupt them, but that's a long standing bug that we can address separately. BUG=266922 TEST=See bug for repro steps. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215836

Patch Set 1 #

Patch Set 2 : Avoid memory error when replacing pending entry. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -18 lines)			Patch
M	content/browser/renderer_host/test_render_view_host.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/navigation_controller_impl_unittest.cc	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1	1 chunk	+22 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

Brett, can you take a look? There's some other changes I'd like to make after ...

7 years, 4 months ago (2013-08-03 00:58:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/21913003/11001

7 years, 4 months ago (2013-08-06 00:02:44 UTC) #3

Message was sent while issue was closed.

Change committed as 215836

Expand Messages | Collapse Messages