Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 21913003: Ensure that renderer-initiated pending entries can be replaced when a new (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Avoid memory error when replacing pending entry. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/navigation_controller_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index e9f0a1fbe573161ba62c43c6e8df9b24d7b304ee..3fdf66c8ac23d24884e15390ad533e5780f42da6 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2133,24 +2133,30 @@ void WebContentsImpl::DidStartProvisionalLoadForFrame(
render_view_host->GetProcess();
RenderViewHost::FilterURL(render_process_host, false, &validated_url);
- if (is_main_frame)
+ if (is_main_frame) {
DidChangeLoadProgress(0);
- // Create a pending entry for this provisional load (if none exists) using the
- // current SiteInstance, and ensure the address bar updates accordingly.
- // We don't know the referrer or extra headers at this point, but the referrer
- // will be set properly upon commit.
- if (is_main_frame && !controller_.GetPendingEntry()) {
- NavigationEntryImpl* entry = NavigationEntryImpl::FromNavigationEntry(
- controller_.CreateNavigationEntry(validated_url,
- content::Referrer(),
- content::PAGE_TRANSITION_LINK,
- true /* is_renderer_initiated */,
- std::string(), GetBrowserContext()));
- entry->set_site_instance(
- static_cast<SiteInstanceImpl*>(GetSiteInstance()));
- controller_.SetPendingEntry(entry);
- NotifyNavigationStateChanged(content::INVALIDATE_TYPE_URL);
+ // If there is no browser-initiated pending entry for this navigation,
+ // create one using the current SiteInstance, and ensure the address bar
+ // updates accordingly. We don't know the referrer or extra headers at this
+ // point, but the referrer will be set properly upon commit.
+ NavigationEntry* pending_entry = controller_.GetPendingEntry();
+ bool has_browser_initiated_pending_entry = pending_entry &&
+ !NavigationEntryImpl::FromNavigationEntry(pending_entry)->
+ is_renderer_initiated();
+ if (!has_browser_initiated_pending_entry) {
+ NavigationEntryImpl* entry = NavigationEntryImpl::FromNavigationEntry(
+ controller_.CreateNavigationEntry(validated_url,
+ content::Referrer(),
+ content::PAGE_TRANSITION_LINK,
+ true /* is_renderer_initiated */,
+ std::string(),
+ GetBrowserContext()));
+ entry->set_site_instance(
+ static_cast<SiteInstanceImpl*>(GetSiteInstance()));
+ controller_.SetPendingEntry(entry);
+ NotifyNavigationStateChanged(content::INVALIDATE_TYPE_URL);
+ }
}
// Notify observers about the start of the provisional load.
« no previous file with comments | « content/browser/web_contents/navigation_controller_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698