third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html - Issue 2186923002: Remove grammar checking from layout tests, and MockGrammarCheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html

Issue 2186923002: Remove grammar checking from layout tests, and MockGrammarCheck (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveGrammarTests

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt ('k') | third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html

diff --git a/third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html b/third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html

index da206462e2095ead8db873d705471da123d883ff..54dbf293563e868cf52e4dd8ec1a42085f88e344 100644

--- a/third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html

+++ b/third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html

@@ -27,7 +27,7 @@ body { overflow:hidden; }

</head>

<body>

-description("This tests the correct placement of inline spelling and grammar "

+description("This tests the correct placement of inline spelling "

+ "markers in text. Spelling markers should line up exactly under misspelled "

+ "words in all cases.");

@@ -72,22 +72,15 @@ function verifyMarkers()

if (!window.internals)

return done();

- // Take care of spelling markers first.

shouldBecomeEqual('internals.hasSpellingMarker(document, 8, 4)', 'true', function() { // Verifies 'adlj'.

shouldBecomeEqual('internals.hasSpellingMarker(document, 13, 6)', 'true', function() { // Verifies 'adaasj'.

- shouldBecomeEqual('internals.hasSpellingMarker(document, 20, 5)', 'true', verifyGrammarMarkers) // Verifies 'sdklj'.

- })

- });

- function verifyGrammarMarkers() {

- shouldBecomeEqual('internals.hasGrammarMarker(document, 4, 3)', 'true', function() { // Verifies second 'the'.

- shouldBecomeEqual('internals.hasGrammarMarker(document, 33, 5)', 'true', function() { // Verifies second 'there'.

+ shouldBecomeEqual('internals.hasSpellingMarker(document, 20, 5)', 'true', function() { // Verifies 'sdklj'.

// Markers of next element can not be found after modification selection without blur event.

div.blur();

done();

})

- });

- }

+ })

+ });

}

var tests = [ function() { moveCursorOverAllWords('testLTR'); },