Remove grammar checking from layout tests, and MockGrammarCheck

Remove grammar checking from layout tests, and MockGrammarCheck

Since Chromium and Blink do not support grammar checking, this patch
removes grammar checking from the following layout tests:

spelling/markers.html
spelling/inline_spelling_markers.html
spelling/inline-spelling-markers-hidpi.html
spelling/inline-spelling-markers-hidpi-composited.html

The last three tests use pixel tests, and are temporarily marked
as failing. They will be unmarked after the grammar marks are removed
from their pixel results.

This patch also removes the class MockGrammarCheck since its only
purpose is to support grammar checking in tests.

BUG=619452
TEST=n/a; this patch changes test files

Committed: https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3
Cr-Commit-Position: refs/heads/master@{#408347}

[Xiaocheng, 2016-07-27 12:19:59]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 12:20:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-07-27 12:23:40]

Description was changed from

==========
Remove MockGrammarCheck

This patch removes MockGrammarCheck because Chromium and Blink do not
support grammar checking, and this class is only used in testing.

BUG=619452
TEST=n/a; this patch changes test files
==========

to

==========
Remove grammar checking from layout tests, and MockGrammarCheck

Since Chromium and Blink do not support grammar checking, this patch
removes grammar checking from the following layout tests:

spelling/markers.html
spelling/inline_spelling_markers.html
spelling/inline-spelling-markers-hidpi.html
spelling/inline-spelling-markers-hidpi-composited.html

The last three tests use pixel tests, and are temporarily marked
as failing. They will be unmarked after the grammar marks are removed
from their pixel results.

This patch also removes the class MockGrammarCheck since its only
purpose is to support grammar checking in tests.

BUG=619452
TEST=n/a; this patch changes test files
==========

[commit-bot: I haz the power, 2016-07-27 13:25:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 13:25:07]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-07-28 01:24:19]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-07-28 01:24:19]

PTAL.

[yosin_UTC9, 2016-07-28 01:44:40]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2016-07-28 01:44:41]

lgtm from editing point of view

+tken@ for OWNERS review.

https://codereview.chromium.org/2186923002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2186923002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1373: crbug.com/619452
editing/spelling/inline_spelling_markers.html [ Failure ]
Can we use |NeedsRebaseline| to update pixel reference files?

[tkent, 2016-07-28 01:53:28]

test_runner lgtm

[Xiaocheng, 2016-07-28 02:15:25]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 02:15:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-07-28 02:22:10]

PTAL at Patch 3.

Am I using NeedsRebaseline in the correct way?

https://codereview.chromium.org/2186923002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2186923002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1373: crbug.com/619452
editing/spelling/inline_spelling_markers.html [ Failure ]
On 2016/07/28 at 01:44:41, Yosi_UTC9 wrote:
> Can we use |NeedsRebaseline| to update pixel reference files?

Didn't know about that. Done.

[yosin_UTC9, 2016-07-28 02:26:36]

On 2016/07/28 at 02:22:10, xiaochengh wrote:
> PTAL at Patch 3.
> 
> Am I using NeedsRebaseline in the correct way?
> 
>
https://codereview.chromium.org/2186923002/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/2186923002/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/TestExpectations:1373: crbug.com/619452
editing/spelling/inline_spelling_markers.html [ Failure ]
> On 2016/07/28 at 01:44:41, Yosi_UTC9 wrote:
> > Can we use |NeedsRebaseline| to update pixel reference files?
> 
> Didn't know about that. Done.

After applying patch and build. Rebaseline bots updates test expectations marked
|NeedsRebaseline|.

http://dev.chromium.org/developers/testing/webkit-layout-tests/testexpectatio...

[Xiaocheng, 2016-07-28 02:29:27]

On 2016/07/28 at 02:26:36, yosin wrote:
> On 2016/07/28 at 02:22:10, xiaochengh wrote:
> > PTAL at Patch 3.
> > 
> > Am I using NeedsRebaseline in the correct way?
> > 
> >
https://codereview.chromium.org/2186923002/diff/20001/third_party/WebKit/Layo...
> > File third_party/WebKit/LayoutTests/TestExpectations (right):
> > 
> >
https://codereview.chromium.org/2186923002/diff/20001/third_party/WebKit/Layo...
> > third_party/WebKit/LayoutTests/TestExpectations:1373: crbug.com/619452
editing/spelling/inline_spelling_markers.html [ Failure ]
> > On 2016/07/28 at 01:44:41, Yosi_UTC9 wrote:
> > > Can we use |NeedsRebaseline| to update pixel reference files?
> > 
> > Didn't know about that. Done.
> 
> After applying patch and build. Rebaseline bots updates test expectations
marked |NeedsRebaseline|.
> 
>
http://dev.chromium.org/developers/testing/webkit-layout-tests/testexpectatio...

Yeah, I followed that document.

Guess I'm doing it in the correct way, so I'll commit Patch 3.

[commit-bot: I haz the power, 2016-07-28 03:17:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 03:17:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xiaocheng, 2016-07-28 04:49:16]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 04:49:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 06:40:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 06:40:29]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-07-28 06:52:31]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-07-28 06:52:31]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2186923002/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2016-07-28 06:52:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 07:00:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-28 07:02:52]

Description was changed from

==========
Remove grammar checking from layout tests, and MockGrammarCheck

Since Chromium and Blink do not support grammar checking, this patch
removes grammar checking from the following layout tests:

spelling/markers.html
spelling/inline_spelling_markers.html
spelling/inline-spelling-markers-hidpi.html
spelling/inline-spelling-markers-hidpi-composited.html

The last three tests use pixel tests, and are temporarily marked
as failing. They will be unmarked after the grammar marks are removed
from their pixel results.

This patch also removes the class MockGrammarCheck since its only
purpose is to support grammar checking in tests.

BUG=619452
TEST=n/a; this patch changes test files
==========

to

==========
Remove grammar checking from layout tests, and MockGrammarCheck

Since Chromium and Blink do not support grammar checking, this patch
removes grammar checking from the following layout tests:

spelling/markers.html
spelling/inline_spelling_markers.html
spelling/inline-spelling-markers-hidpi.html
spelling/inline-spelling-markers-hidpi-composited.html

The last three tests use pixel tests, and are temporarily marked
as failing. They will be unmarked after the grammar marks are removed
from their pixel results.

This patch also removes the class MockGrammarCheck since its only
purpose is to support grammar checking in tests.

BUG=619452
TEST=n/a; this patch changes test files

Committed: https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3
Cr-Commit-Position: refs/heads/master@{#408347}
==========

[commit-bot: I haz the power, 2016-07-28 07:02:53]

Patchset 4 (id:??) landed as
https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3
Cr-Commit-Position: refs/heads/master@{#408347}