Issue 21752002: Support MSAA in the picture debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21752002: Support MSAA in the picture debugger (Closed)

Created:
7 years, 4 months ago by Kimmo Kinnunen

Modified:
7 years, 4 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Support MSAA in the picture debugger Add radio buttons for setting the GL sample count to 0 ("off"), 4 or 16. Change the default mode of the GL widget to MSAA4. Previous behavior corresponded to "off". BUG=1459 Committed: http://code.google.com/p/skia/source/detail?r=10509

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -7 lines)			Patch
M	debugger/QT/SkCanvasWidget.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	debugger/QT/SkCanvasWidget.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	debugger/QT/SkGLWidget.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	debugger/QT/SkGLWidget.cpp	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	debugger/QT/SkSettingsWidget.h	View	4 chunks	+21 lines, -2 lines	0 comments	Download
M	debugger/QT/SkSettingsWidget.cpp	View	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/21752002/1

7 years, 4 months ago (2013-08-02 13:03:31 UTC) #3

Message was sent while issue was closed.

Change committed as 10509

Expand Messages | Collapse Messages