Only submit HomePageIsNewTabPage metric when ShowHomeButton is enabled

Only submit HomePageIsNewTabPage metric when ShowHomeButton is enabled

This is a rebased version of https://chromiumcodereview.appspot.com/20722007 which was reverted due to a reverted branch dependency.

BUG=266902
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215935

[Ken Rockot(use gerrit already), 2013-08-05 20:06:43]

PTAL

[Mark P, 2013-08-05 20:09:24]

Has the original change made it to dev or beta (on any branch) at this point?

--mark

[Ken Rockot(use gerrit already), 2013-08-05 20:16:49]

On 2013/08/05 20:09:24, Mark P wrote:
> Has the original change made it to dev or beta (on any branch) at this point?
> 
> --mark

The original change is in M29, yes.

[Mark P, 2013-08-05 20:17:46]

On Mon, Aug 5, 2013 at 1:16 PM, <rockot@chromium.org> wrote:

> On 2013/08/05 20:09:24, Mark P wrote:
>
>> Has the original change made it to dev or beta (on any branch) at this
>> point?
>>
>
>  --mark
>>
>
> The original change is in M29, yes.
>

Then a good practice is to rename the histogram and mark the old one as
obsolete.  You don't want to mix bad data with good.

--mark


>
>
https://codereview.chromium.**org/21690005/<https://codereview.chromium.org/2...
>

[Ken Rockot(use gerrit already), 2013-08-05 20:23:15]

> a good practice is to rename the histogram and mark the old one as
> obsolete.  You don't want to mix bad data with good.

Thanks. SGTM and done.

[Mark P, 2013-08-05 21:25:49]

https://codereview.chromium.org/21690005/diff/10001/chrome/browser/prefs/pref...
File chrome/browser/prefs/pref_metrics_service.cc (right):

https://codereview.chromium.org/21690005/diff/10001/chrome/browser/prefs/pref...
chrome/browser/prefs/pref_metrics_service.cc:29:
UMA_HISTOGRAM_BOOLEAN("Settings.InUseHomePageIsNewTabPage",
This name is icky.  How about something clearer such as
Settings.GivenShowHomeButton_HomePageIsNewTabPage?

https://codereview.chromium.org/21690005/diff/10001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/21690005/diff/10001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:13110: when a profile is loaded. This is
only logged if the Home button is enabled.
^Home button is enabled^home button is shown

[Ken Rockot(use gerrit already), 2013-08-05 21:48:31]

https://codereview.chromium.org/21690005/diff/10001/chrome/browser/prefs/pref...
File chrome/browser/prefs/pref_metrics_service.cc (right):

https://codereview.chromium.org/21690005/diff/10001/chrome/browser/prefs/pref...
chrome/browser/prefs/pref_metrics_service.cc:29:
UMA_HISTOGRAM_BOOLEAN("Settings.InUseHomePageIsNewTabPage",
On 2013/08/05 21:25:49, Mark P wrote:
> This name is icky.  How about something clearer such as
> Settings.GivenShowHomeButton_HomePageIsNewTabPage?

Done.

https://codereview.chromium.org/21690005/diff/10001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/21690005/diff/10001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:13110: when a profile is loaded. This is
only logged if the Home button is enabled.
On 2013/08/05 21:25:49, Mark P wrote:
> ^Home button is enabled^home button is shown

Done.

[Mark P, 2013-08-05 22:00:53]

minor nit that you missed before, other lgtm

https://codereview.chromium.org/21690005/diff/16001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/21690005/diff/16001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:13101: when a profile is loaded. This is
only logged if the Home button is shown.
nit: lowercase Home please

[Ken Rockot(use gerrit already), 2013-08-05 22:12:51]

On 2013/08/05 22:00:53, Mark P wrote:
> minor nit that you missed before, other lgtm
> 
>
https://codereview.chromium.org/21690005/diff/16001/tools/metrics/histograms/...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/21690005/diff/16001/tools/metrics/histograms/...
> tools/metrics/histograms/histograms.xml:13101: when a profile is loaded. This
is
> only logged if the Home button is shown.
> nit: lowercase Home please

Wasn't sure if that was intentional. In that case I've changed both occurrences
in the relevant summaries.

[battre, 2013-08-06 15:13:48]

lgtm

[commit-bot: I haz the power, 2013-08-06 15:53:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/21690005/22001

[commit-bot: I haz the power, 2013-08-06 18:26:41]

Change committed as 215935