Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 20722007: Only log HomePageIsNewTabPage if home button is enabled (Closed)

Created:
7 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
7 years, 4 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Only log HomePageIsNewTabPage if home button is enabled BUG=266902 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215147

Patch Set 1 #

Patch Set 2 : Cleanup and reapply #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M chrome/browser/prefs/pref_metrics_service.cc View 1 1 chunk +10 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Ken Rockot(use gerrit already)
PTAL
7 years, 4 months ago (2013-08-01 15:31:09 UTC) #1
Alexei Svitkine (slow)
LGTM
7 years, 4 months ago (2013-08-01 15:34:33 UTC) #2
battre
lgtm
7 years, 4 months ago (2013-08-01 17:20:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/20722007/1
7 years, 4 months ago (2013-08-01 20:30:38 UTC) #4
commit-bot: I haz the power
Change committed as 215147
7 years, 4 months ago (2013-08-01 23:59:10 UTC) #5
Ken Rockot(use gerrit already)
7 years, 4 months ago (2013-08-02 21:31:02 UTC) #6
Message was sent while issue was closed.
Cleanup and reapply

Powered by Google App Engine
This is Rietveld 408576698