Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 21643002: Canvas focus outline should match style in html.css. (Closed)

Created:
7 years, 4 months ago by dmazzoni
Modified:
7 years, 4 months ago
Reviewers:
Stephen White
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Canvas focus outline should match style in html.css. The default style of an element isn't quite right. The style that most elements get by default when focused is defined in html.css. There's no easy way to access this, so this change hardcodes the values and adds a comment. BUG=261998 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155532

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed element argument #

Patch Set 3 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 2 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dmazzoni
7 years, 4 months ago (2013-08-01 23:11:54 UTC) #1
Stephen White
LGTM https://codereview.chromium.org/21643002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): https://codereview.chromium.org/21643002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp#newcode2392 Source/core/html/canvas/CanvasRenderingContext2D.cpp:2392: void CanvasRenderingContext2D::drawFocusRing(const Path& path, Element* element) Not new ...
7 years, 4 months ago (2013-08-05 14:29:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/21643002/6001
7 years, 4 months ago (2013-08-05 15:30:23 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-05 15:50:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/21643002/18001
7 years, 4 months ago (2013-08-05 15:55:41 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-05 18:19:48 UTC) #6
Message was sent while issue was closed.
Change committed as 155532

Powered by Google App Engine
This is Rietveld 408576698