net: make CanonicalCookie's constructor private

net: make CanonicalCookie's constructor private

Since almost everything was converted to Create method, now
it can be moved to private section.

While doing this, CanonicalCookieTest::Constructor had to be
converted to Create method as well.

BUG=57061
TEST=net_unittests --gtest_filter=CanonicalCookieTest.Constructor
TEST=ios_net_unittests
R=mmenke@chromium.org

Committed: https://crrev.com/9c770cf31089d791900b601bbc94ce49b4673b4f
Cr-Commit-Position: refs/heads/master@{#407312}

[tfarina, 2016-07-19 22:05:44]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 22:06:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 22:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 22:10:05]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tfarina, 2016-07-19 22:28:56]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 22:29:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 22:38:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 22:38:08]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[tfarina, 2016-07-20 09:21:59]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 09:22:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 09:28:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 09:28:55]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tfarina, 2016-07-20 09:50:40]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 09:50:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 09:55:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 09:55:29]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[tfarina, 2016-07-20 11:57:33]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 11:58:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 12:05:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 12:05:31]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[tfarina, 2016-07-20 12:10:07]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 12:10:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 12:20:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 12:20:37]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[tfarina, 2016-07-20 19:41:48]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 19:42:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 19:45:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 19:45:04]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[tfarina, 2016-07-20 19:57:37]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 19:58:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-07-20 20:26:01]

Matt, when you have a spare time, could you take a look at the astronomical
failures in ios_net_unittests?

As I should have antecipated, there were more uses than codesearch could find
(this is a thing that Grok should learn one day, how to index on other platforms
like Mac and Windows).

[mmenke, 2016-07-20 20:50:11]

Not a full review, just trying to figure out what's going wrong on iOS.

https://codereview.chromium.org/2159373002/diff/70005/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_cache_unittest.cc (right):

https://codereview.chromium.org/2159373002/diff/70005/ios/net/cookies/cookie_...
ios/net/cookies/cookie_cache_unittest.cc:20: return
*CanonicalCookie::Create(url, name, value, url.host(), url.path(),
url.host() should be std::string(), to maintain behavior.

https://codereview.chromium.org/2159373002/diff/70005/ios/net/cookies/system_...
File ios/net/cookies/system_cookie_util.mm (right):

https://codereview.chromium.org/2159373002/diff/70005/ios/net/cookies/system_...
ios/net/cookies/system_cookie_util.mm:70: GURL("http://example.com"),
base::SysNSStringToUTF8([cookie name]),
I think this one is the issue.  Switch it to using the constructor that doesn't
take a GURL, and I think iOS will magically work.  (i.e, just delete the first
argument)

[commit-bot: I haz the power, 2016-07-20 21:15:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 21:15:49]

Dry run: Try jobs failed on following builders:
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[tfarina, 2016-07-20 21:16:56]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 21:17:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-07-20 21:58:48]

Still in fire. I have sent an email to Sylvain asking for help on how to run the
test under iossim to see if I can reproduce locally, so I can better look at it.

https://codereview.chromium.org/2159373002/diff/70005/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_cache_unittest.cc (right):

https://codereview.chromium.org/2159373002/diff/70005/ios/net/cookies/cookie_...
ios/net/cookies/cookie_cache_unittest.cc:20: return
*CanonicalCookie::Create(url, name, value, url.host(), url.path(),
On 2016/07/20 20:50:11, mmenke wrote:
> url.host() should be std::string(), to maintain behavior.

Done.

https://codereview.chromium.org/2159373002/diff/70005/ios/net/cookies/system_...
File ios/net/cookies/system_cookie_util.mm (right):

https://codereview.chromium.org/2159373002/diff/70005/ios/net/cookies/system_...
ios/net/cookies/system_cookie_util.mm:70: GURL("http://example.com"),
base::SysNSStringToUTF8([cookie name]),
On 2016/07/20 20:50:11, mmenke wrote:
> I think this one is the issue.  Switch it to using the constructor that
doesn't
> take a GURL, and I think iOS will magically work.  (i.e, just delete the first
> argument)

Done.

[commit-bot: I haz the power, 2016-07-20 22:04:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 22:04:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tfarina, 2016-07-21 09:11:05]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 09:11:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 10:06:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 10:06:10]

Dry run: Try jobs failed on following builders:
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[tfarina, 2016-07-21 10:11:53]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 10:12:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 11:07:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 11:07:39]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-07-21 15:34:57]

LGTM!  Good work on these.

https://codereview.chromium.org/2159373002/diff/180001/chrome/browser/android...
File chrome/browser/android/cookies/cookies_fetcher.cc (right):

https://codereview.chromium.org/2159373002/diff/180001/chrome/browser/android...
chrome/browser/android/cookies/cookies_fetcher.cc:161:
GURL("http://example.com"), base::android::ConvertJavaStringToUTF8(env, name),
Should just remove this GURL.  Looks like no tests are running this code, or
they'd fail.  :(

https://codereview.chromium.org/2159373002/diff/180001/ios/net/cookies/cookie...
File ios/net/cookies/cookie_store_ios_unittest.mm (right):

https://codereview.chromium.org/2159373002/diff/180001/ios/net/cookies/cookie...
ios/net/cookies/cookie_store_ios_unittest.mm:263: net::CanonicalCookie::Create(
To keep old behavior, add "GURL("http://domain/")" as the first parmeter.

https://codereview.chromium.org/2159373002/diff/180001/net/cookies/canonical_...
File net/cookies/canonical_cookie.cc (right):

https://codereview.chromium.org/2159373002/diff/180001/net/cookies/canonical_...
net/cookies/canonical_cookie.cc:132: CanonicalCookie::CanonicalCookie(const
GURL& url,
nit:  This should be moved down below FullCompare, to match declaration order.

[tfarina, 2016-07-21 18:51:29]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 18:52:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-07-21 19:05:41]

tfarina@chromium.org changed reviewers:
+ dfalcantara@chromium.org, droger@chromium.org

[tfarina, 2016-07-21 19:05:42]

Adding onwers for android and ios changes.

c/b/android/cookies -> dfalcantara
ios/net/cookies -> droger

https://codereview.chromium.org/2159373002/diff/180001/chrome/browser/android...
File chrome/browser/android/cookies/cookies_fetcher.cc (right):

https://codereview.chromium.org/2159373002/diff/180001/chrome/browser/android...
chrome/browser/android/cookies/cookies_fetcher.cc:161:
GURL("http://example.com"), base::android::ConvertJavaStringToUTF8(env, name),
On 2016/07/21 15:34:57, mmenke wrote:
> Should just remove this GURL.  Looks like no tests are running this code, or
> they'd fail.  :(

Done.

https://codereview.chromium.org/2159373002/diff/180001/ios/net/cookies/cookie...
File ios/net/cookies/cookie_store_ios_unittest.mm (right):

https://codereview.chromium.org/2159373002/diff/180001/ios/net/cookies/cookie...
ios/net/cookies/cookie_store_ios_unittest.mm:263: net::CanonicalCookie::Create(
On 2016/07/21 15:34:57, mmenke wrote:
> To keep old behavior, add "GURL("http://domain/")" as the first parmeter.

Done.

https://codereview.chromium.org/2159373002/diff/180001/net/cookies/canonical_...
File net/cookies/canonical_cookie.cc (right):

https://codereview.chromium.org/2159373002/diff/180001/net/cookies/canonical_...
net/cookies/canonical_cookie.cc:132: CanonicalCookie::CanonicalCookie(const
GURL& url,
On 2016/07/21 15:34:57, mmenke wrote:
> nit:  This should be moved down below FullCompare, to match declaration order.

Looks like CanonPath is not at the right place either, but I'm not going to move
it, just the code I'm touching.

https://codereview.chromium.org/2159373002/diff/180001/net/cookies/canonical_...
net/cookies/canonical_cookie.cc:132: CanonicalCookie::CanonicalCookie(const
GURL& url,
On 2016/07/21 15:34:57, mmenke wrote:
> nit:  This should be moved down below FullCompare, to match declaration order.

Done.

[gone, 2016-07-21 19:47:24]

Android lgtm

[commit-bot: I haz the power, 2016-07-21 19:53:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:53:17]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[droger, 2016-07-22 08:58:10]

https://chromiumcodereview.appspot.com/2159373002/diff/200001/ios/net/cookies...
File ios/net/cookies/cookie_store_ios_unittest.mm (right):

https://chromiumcodereview.appspot.com/2159373002/diff/200001/ios/net/cookies...
ios/net/cookies/cookie_store_ios_unittest.mm:263:
net::CanonicalCookie::Create(GURL("http://domain"), "name",
Is this now returning NULL?

Could it be because the domain is the empty string?

[tfarina, 2016-07-22 10:36:54]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 10:37:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-07-22 11:14:40]

Description was changed from

==========
net: make CanonicalCookie's constructor private

Since almost everything was converted to Create method, now
it can be moved to private section.

While doing this, CanonicalCookieTest::Constructor had to be
converted to Create method as well.

BUG=57061
TEST=net_unittests --gtest_filter=CanonicalCookieTest.Constructor
R=mmenke@chromium.org
==========

to

==========
net: make CanonicalCookie's constructor private

Since almost everything was converted to Create method, now
it can be moved to private section.

While doing this, CanonicalCookieTest::Constructor had to be
converted to Create method as well.

BUG=57061
TEST=net_unittests --gtest_filter=CanonicalCookieTest.Constructor
TEST=ios_net_unittests
R=mmenke@chromium.org
==========

[commit-bot: I haz the power, 2016-07-22 11:16:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 11:16:41]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tfarina, 2016-07-22 12:37:16]

https://chromiumcodereview.appspot.com/2159373002/diff/200001/ios/net/cookies...
File ios/net/cookies/cookie_store_ios_unittest.mm (right):

https://chromiumcodereview.appspot.com/2159373002/diff/200001/ios/net/cookies...
ios/net/cookies/cookie_store_ios_unittest.mm:263:
net::CanonicalCookie::Create(GURL("http://domain"), "name",
On 2016/07/22 08:58:10, droger wrote:
> Is this now returning NULL?
> 
> Could it be because the domain is the empty string?
I added it back but I think it still returns NULL. Matt, could you advise here
what is the right fix for creating a bad canonical cookie?

[mmenke, 2016-07-22 14:52:44]

https://chromiumcodereview.appspot.com/2159373002/diff/200001/ios/net/cookies...
File ios/net/cookies/cookie_store_ios_unittest.mm (right):

https://chromiumcodereview.appspot.com/2159373002/diff/200001/ios/net/cookies...
ios/net/cookies/cookie_store_ios_unittest.mm:263:
net::CanonicalCookie::Create(GURL("http://domain"), "name",
On 2016/07/22 12:37:15, tfarina wrote:
> On 2016/07/22 08:58:10, droger wrote:
> > Is this now returning NULL?
> > 
> > Could it be because the domain is the empty string?
> I added it back but I think it still returns NULL. Matt, could you advise here
> what is the right fix for creating a bad canonical cookie?

I think the path is invalid - it needs a leading slash (i.e. "/path/").  Code so
often creating invalid cookies is just the reason for switching to the
validating constructor.

[tfarina, 2016-07-22 19:18:50]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 19:19:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-07-22 19:50:01]

droger, could you take another look?

https://chromiumcodereview.appspot.com/2159373002/diff/200001/ios/net/cookies...
File ios/net/cookies/cookie_store_ios_unittest.mm (right):

https://chromiumcodereview.appspot.com/2159373002/diff/200001/ios/net/cookies...
ios/net/cookies/cookie_store_ios_unittest.mm:263:
net::CanonicalCookie::Create(GURL("http://domain"), "name",
On 2016/07/22 14:52:44, mmenke wrote:
> On 2016/07/22 12:37:15, tfarina wrote:
> > On 2016/07/22 08:58:10, droger wrote:
> > > Is this now returning NULL?
> > > 
> > > Could it be because the domain is the empty string?
> > I added it back but I think it still returns NULL. Matt, could you advise
here
> > what is the right fix for creating a bad canonical cookie?
> 
> I think the path is invalid - it needs a leading slash (i.e. "/path/").  Code
so
> often creating invalid cookies is just the reason for switching to the
> validating constructor.

Thanks Matt! ios_net_unittests is green again with this.

[mmenke, 2016-07-22 20:10:29]

https://codereview.chromium.org/2159373002/diff/240001/ios/net/cookies/cookie...
File ios/net/cookies/cookie_store_ios_unittest.mm (right):

https://codereview.chromium.org/2159373002/diff/240001/ios/net/cookies/cookie...
ios/net/cookies/cookie_store_ios_unittest.mm:264:
"\x81r\xe4\xbd\xa0\xe5\xa5\xbd", "domain",
Could you either replace "domain" with std::string() or make it ".domain", so it
corresponds to a valid cookie line (Currently "domain" is mapped to ".domain"
due to buggy servers - I'd suggest just using std::string() to match old
behavior, but doesn't really matter).

[droger, 2016-07-22 20:27:07]

lgtm

[tfarina, 2016-07-22 20:44:14]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 20:44:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-07-22 21:16:02]

https://codereview.chromium.org/2159373002/diff/240001/ios/net/cookies/cookie...
File ios/net/cookies/cookie_store_ios_unittest.mm (right):

https://codereview.chromium.org/2159373002/diff/240001/ios/net/cookies/cookie...
ios/net/cookies/cookie_store_ios_unittest.mm:264:
"\x81r\xe4\xbd\xa0\xe5\xa5\xbd", "domain",
On 2016/07/22 20:10:29, mmenke wrote:
> Could you either replace "domain" with std::string() or make it ".domain", so
it
> corresponds to a valid cookie line (Currently "domain" is mapped to ".domain"
> due to buggy servers - I'd suggest just using std::string() to match old
> behavior, but doesn't really matter).

Done.

[commit-bot: I haz the power, 2016-07-22 22:11:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 22:11:50]

Dry run: This issue passed the CQ dry run.

[tfarina, 2016-07-23 00:14:01]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2016-07-23 00:14:02]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org,
dfalcantara@chromium.org, droger@chromium.org
Link to the patchset: https://codereview.chromium.org/2159373002/#ps260001
(title: "domain")

[commit-bot: I haz the power, 2016-07-23 00:14:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 00:18:28]

Description was changed from

==========
net: make CanonicalCookie's constructor private

Since almost everything was converted to Create method, now
it can be moved to private section.

While doing this, CanonicalCookieTest::Constructor had to be
converted to Create method as well.

BUG=57061
TEST=net_unittests --gtest_filter=CanonicalCookieTest.Constructor
TEST=ios_net_unittests
R=mmenke@chromium.org
==========

to

==========
net: make CanonicalCookie's constructor private

Since almost everything was converted to Create method, now
it can be moved to private section.

While doing this, CanonicalCookieTest::Constructor had to be
converted to Create method as well.

BUG=57061
TEST=net_unittests --gtest_filter=CanonicalCookieTest.Constructor
TEST=ios_net_unittests
R=mmenke@chromium.org
==========

[commit-bot: I haz the power, 2016-07-23 00:18:30]

Committed patchset #15 (id:260001)

[commit-bot: I haz the power, 2016-07-23 00:20:22]

Description was changed from

==========
net: make CanonicalCookie's constructor private

Since almost everything was converted to Create method, now
it can be moved to private section.

While doing this, CanonicalCookieTest::Constructor had to be
converted to Create method as well.

BUG=57061
TEST=net_unittests --gtest_filter=CanonicalCookieTest.Constructor
TEST=ios_net_unittests
R=mmenke@chromium.org
==========

to

==========
net: make CanonicalCookie's constructor private

Since almost everything was converted to Create method, now
it can be moved to private section.

While doing this, CanonicalCookieTest::Constructor had to be
converted to Create method as well.

BUG=57061
TEST=net_unittests --gtest_filter=CanonicalCookieTest.Constructor
TEST=ios_net_unittests
R=mmenke@chromium.org

Committed: https://crrev.com/9c770cf31089d791900b601bbc94ce49b4673b4f
Cr-Commit-Position: refs/heads/master@{#407312}
==========

[commit-bot: I haz the power, 2016-07-23 00:20:24]

Patchset 15 (id:??) landed as
https://crrev.com/9c770cf31089d791900b601bbc94ce49b4673b4f
Cr-Commit-Position: refs/heads/master@{#407312}