Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1658)

Unified Diff: net/cookies/canonical_cookie_unittest.cc

Issue 2159373002: net: make CanonicalCookie's constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: domain Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/canonical_cookie.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/canonical_cookie_unittest.cc
diff --git a/net/cookies/canonical_cookie_unittest.cc b/net/cookies/canonical_cookie_unittest.cc
index a52326391571b9cf47baf453bfdc5d562d13d7e0..b6bff7f07892b654a7d0349b7a81ba9e4cc63c06 100644
--- a/net/cookies/canonical_cookie_unittest.cc
+++ b/net/cookies/canonical_cookie_unittest.cc
@@ -18,28 +18,28 @@ TEST(CanonicalCookieTest, Constructor) {
GURL url("http://www.example.com/test");
base::Time current_time = base::Time::Now();
- CanonicalCookie cookie(url, "A", "2", "www.example.com", "/test",
- current_time, base::Time(), current_time, false, false,
- CookieSameSite::DEFAULT_MODE, COOKIE_PRIORITY_DEFAULT);
- EXPECT_EQ("A", cookie.Name());
- EXPECT_EQ("2", cookie.Value());
- EXPECT_EQ("www.example.com", cookie.Domain());
- EXPECT_EQ("/test", cookie.Path());
- EXPECT_FALSE(cookie.IsSecure());
- EXPECT_FALSE(cookie.IsHttpOnly());
- EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cookie.SameSite());
-
- CanonicalCookie cookie2(url, "A", "2", std::string(), std::string(),
- current_time, base::Time(), current_time, false,
- false, CookieSameSite::DEFAULT_MODE,
- COOKIE_PRIORITY_DEFAULT);
- EXPECT_EQ("A", cookie2.Name());
- EXPECT_EQ("2", cookie2.Value());
- EXPECT_EQ("", cookie2.Domain());
- EXPECT_EQ("", cookie2.Path());
- EXPECT_FALSE(cookie2.IsSecure());
- EXPECT_FALSE(cookie2.IsHttpOnly());
- EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cookie2.SameSite());
+ std::unique_ptr<CanonicalCookie> cookie(CanonicalCookie::Create(
+ url, "A", "2", std::string(), "/test", current_time, base::Time(), false,
+ false, CookieSameSite::DEFAULT_MODE, false, COOKIE_PRIORITY_DEFAULT));
+ EXPECT_EQ("A", cookie->Name());
+ EXPECT_EQ("2", cookie->Value());
+ EXPECT_EQ("www.example.com", cookie->Domain());
+ EXPECT_EQ("/test", cookie->Path());
+ EXPECT_FALSE(cookie->IsSecure());
+ EXPECT_FALSE(cookie->IsHttpOnly());
+ EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cookie->SameSite());
+
+ std::unique_ptr<CanonicalCookie> cookie2(CanonicalCookie::Create(
+ url, "A", "2", ".www.example.com", std::string(), current_time,
+ base::Time(), false, false, CookieSameSite::DEFAULT_MODE, false,
+ COOKIE_PRIORITY_DEFAULT));
+ EXPECT_EQ("A", cookie2->Name());
+ EXPECT_EQ("2", cookie2->Value());
+ EXPECT_EQ(".www.example.com", cookie2->Domain());
+ EXPECT_EQ("/", cookie2->Path());
+ EXPECT_FALSE(cookie2->IsSecure());
+ EXPECT_FALSE(cookie2->IsHttpOnly());
+ EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cookie2->SameSite());
}
TEST(CanonicalCookieTest, Create) {
« no previous file with comments | « net/cookies/canonical_cookie.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698