cc/trees/layer_tree_impl.cc - Issue 2154473004: Add a sanity DCHECK when constructing a UIResourceRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_impl.cc

Issue 2154473004: Add a sanity DCHECK when constructing a UIResourceRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a check that we're deleting when no bitmap is passed to the constructor. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/layer_tree_impl.cc

diff --git a/cc/trees/layer_tree_impl.cc b/cc/trees/layer_tree_impl.cc

index e97ee7f74d9b7a6e812f816b8ca43401673eb786..012f30d3bdb24dc7898bebec7dd86b04f754c61f 100644

--- a/cc/trees/layer_tree_impl.cc

+++ b/cc/trees/layer_tree_impl.cc

@@ -1484,6 +1484,7 @@ bool LayerTreeImpl::IsUIResourceOpaque(UIResourceId uid) const {

void LayerTreeImpl::ProcessUIResourceRequestQueue() {

for (const auto& req : ui_resource_request_queue_) {

+ DCHECK(&req);

vmpstr 2016/07/15 21:29:23 This looks wrong. I think we can assume that the o

Donn Denman 2016/07/15 22:05:56 Removed.

switch (req.GetType()) {

case UIResourceRequest::UI_RESOURCE_CREATE:

layer_tree_host_impl_->CreateUIResource(req.GetId(), req.GetBitmap());

« cc/trees/layer_tree_host_impl.cc ('K') | « cc/trees/layer_tree_host_impl.cc ('k') | no next file » | no next file with comments »