Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 21398002: Collapse ImageSkia.cpp and ImageChromium.cpp into Image.cpp (Closed)

Created:
7 years, 4 months ago by jbroman
Modified:
7 years, 4 months ago
Reviewers:
pdr.
CC:
blink-reviews, jamesr, eae+blinkwatch, danakj, dglazkov+blink, Rik, Stephen Chennney, jeez, pdr.
Visibility:
Public.

Description

Collapse ImageSkia.cpp and ImageChromium.cpp into Image.cpp Also remove declaration of Image::create, which had no implementation in any of these files (or anywhere else!) BUG=242060 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -113 lines) Patch
M Source/core/core.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/Image.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/Image.cpp View 3 chunks +27 lines, -1 line 0 comments Download
D Source/core/platform/graphics/chromium/ImageChromium.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/core/platform/graphics/skia/ImageSkia.cpp View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbroman
7 years, 4 months ago (2013-07-31 21:23:56 UTC) #1
pdr.
Love it! LGTM
7 years, 4 months ago (2013-07-31 21:25:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/21398002/1
7 years, 4 months ago (2013-08-01 12:29:19 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-01 12:34:35 UTC) #4
Message was sent while issue was closed.
Change committed as 155329

Powered by Google App Engine
This is Rietveld 408576698