Rename fileapi::LocalFileSystemOperation to FileSystemOperationImpl.

Rename fileapi::LocalFileSystemOperation to FileSystemOperationImpl.

Drive File System starts to use LocalFileSystemOperation, so it is no longer
"local". As it is the default implementation of FileSystemOperation,
this CL renames it to FileSystemOperationImpl

BUG=261477
TEST=Ran unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215033

[hidehiko, 2013-07-31 15:12:22]

satorux@, could you review c/b/chromeos/fileapi/... as an OWNER?
asargent@, could you review c/b/extensions/api/developer_private/... as an
OWNER?
vandebo@, could you review c/b/media_galleries/fileapi/... as an OWNER?
jochen@, could you review content/content_tests.gypi as an OWNER?
kinuko@ could you review all remaining files?

Thank you for your review in advance,
- hidehiko

[vandebo (ex-Chrome), 2013-07-31 16:52:28]

c/b/media_galleries/ LGTM

[asargent_no_longer_on_chrome, 2013-07-31 23:04:10]

chrome/browser/extensions/api/developer_private/developer_private_api.cc LGTM 

FYI, it looks like just an include location changed in that file - do we
actually use the class in question in that file?

[hidehiko, 2013-08-01 01:38:15]

Thank you for your review, Vandebo, Antony.

On 2013/07/31 23:04:10, Antony Sargent wrote:
> chrome/browser/extensions/api/developer_private/developer_private_api.cc LGTM 
> 
> FYI, it looks like just an include location changed in that file - do we
> actually use the class in question in that file?

Yes. FileSystemOperation, which is declared in file_system_operation.h included
from local_file_system_operation.h, is used in developer_private_api.cc. This CL
fixes the include directive to the right one.

Thanks,
- hidehiko

[kinuko, 2013-08-01 04:09:13]

lgtm

https://codereview.chromium.org/21370003/diff/1/webkit/browser/fileapi/file_s...
File webkit/browser/fileapi/file_system_operation_impl.h (right):

https://codereview.chromium.org/21370003/diff/1/webkit/browser/fileapi/file_s...
webkit/browser/fileapi/file_system_operation_impl.h:99: const StatusCallback&
callback);
Not directly related to this patch, but can (some of) these methods be now
upstreamed to FileSystemOperation interface?

[hidehiko, 2013-08-01 04:22:04]

Thank you for your review.

https://codereview.chromium.org/21370003/diff/1/webkit/browser/fileapi/file_s...
File webkit/browser/fileapi/file_system_operation_impl.h (right):

https://codereview.chromium.org/21370003/diff/1/webkit/browser/fileapi/file_s...
webkit/browser/fileapi/file_system_operation_impl.h:99: const StatusCallback&
callback);
On 2013/08/01 04:09:13, kinuko wrote:
> Not directly related to this patch, but can (some of) these methods be now
> upstreamed to FileSystemOperation interface?

Yes, I think. IIUC, we have two FileSystemOperation implementation. One is this,
and the other is SyncableFileSystemOperation which inherits this.

[jochen (gone - plz use gerrit), 2013-08-01 06:44:39]

content_tests.gypi lgtm

[satorux1, 2013-08-01 07:46:42]

c/b/chromeos/fileapi/ LGTM. sorry to be late.

[hidehiko, 2013-08-01 07:48:55]

Thank you, all, for your review!
Sending to CQ.

- hidehiko

[commit-bot: I haz the power, 2013-08-01 07:49:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/21370003/1

[commit-bot: I haz the power, 2013-08-01 07:49:56]

Failed to apply patch for webkit/browser/fileapi/sandbox_file_system_backend.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file webkit/browser/fileapi/sandbox_file_system_backend.cc
  Hunk #1 FAILED at 18.
  Hunk #2 succeeded at 216 (offset -45 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
webkit/browser/fileapi/sandbox_file_system_backend.cc.rej

Patch:       webkit/browser/fileapi/sandbox_file_system_backend.cc
Index: webkit/browser/fileapi/sandbox_file_system_backend.cc
diff --git a/webkit/browser/fileapi/sandbox_file_system_backend.cc
b/webkit/browser/fileapi/sandbox_file_system_backend.cc
index
e7b0b63eb4b033931e79376773356a894612bb95..fb5901c8116365146d2827247786b0ccb63bd647
100644
--- a/webkit/browser/fileapi/sandbox_file_system_backend.cc
+++ b/webkit/browser/fileapi/sandbox_file_system_backend.cc
@@ -18,10 +18,10 @@
 #include "webkit/browser/fileapi/file_system_context.h"
 #include "webkit/browser/fileapi/file_system_file_stream_reader.h"
 #include "webkit/browser/fileapi/file_system_operation_context.h"
+#include "webkit/browser/fileapi/file_system_operation_impl.h"
 #include "webkit/browser/fileapi/file_system_options.h"
 #include "webkit/browser/fileapi/file_system_task_runners.h"
 #include "webkit/browser/fileapi/file_system_usage_cache.h"
-#include "webkit/browser/fileapi/local_file_system_operation.h"
 #include "webkit/browser/fileapi/obfuscated_file_util.h"
 #include "webkit/browser/fileapi/sandbox_context.h"
 #include "webkit/browser/fileapi/sandbox_file_stream_writer.h"
@@ -261,7 +261,7 @@ FileSystemOperation*
SandboxFileSystemBackend::CreateFileSystemOperation(
   else
     operation_context->set_quota_limit_type(quota::kQuotaLimitTypeLimited);
 
-  return new LocalFileSystemOperation(url, context, operation_context.Pass());
+  return new FileSystemOperationImpl(url, context, operation_context.Pass());
 }
 
 scoped_ptr<webkit_blob::FileStreamReader>

[commit-bot: I haz the power, 2013-08-01 12:12:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/21370003/15001

[commit-bot: I haz the power, 2013-08-01 15:00:14]

Change committed as 215033