Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 21350002: MediaStream API: Update RTCDataChannel to match the specification (Closed)

Created:
6 years, 11 months ago by Tommy Widenflycht
Modified:
6 years, 11 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, dglazkov+blink, abarth-chromium, tommyw+watchlist_chromium.org, jeez, jochen+watch_chromium.org
Visibility:
Public.

Description

MediaStream API: Update RTCDataChannel to match the specification Just adding a bunch of attributes and deprecating one. BUG=266333 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -9 lines) Patch
M Source/core/platform/mediastream/RTCDataChannelHandler.h View 1 chunk +12 lines, -2 lines 0 comments Download
M Source/core/platform/mediastream/RTCDataChannelHandler.cpp View 1 chunk +32 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.h View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.idl View 1 chunk +10 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h View 3 chunks +8 lines, -4 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp View 2 chunks +31 lines, -0 lines 0 comments Download
M public/platform/WebRTCDataChannelHandler.h View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Tommy Widenflycht
6 years, 11 months ago (2013-07-31 12:23:25 UTC) #1
jochen (gone - plz use gerrit)
lgtm can you add a proper BUG= entry
6 years, 11 months ago (2013-07-31 13:40:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/21350002/1
6 years, 11 months ago (2013-07-31 14:06:33 UTC) #3
Tommy Widenflycht
On 2013/07/31 13:40:01, jochen wrote: > > can you add a proper BUG= entry Done.
6 years, 11 months ago (2013-07-31 14:14:04 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2013-07-31 16:38:47 UTC) #5
Message was sent while issue was closed.
Change committed as 155254

Powered by Google App Engine
This is Rietveld 408576698