third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl - Issue 2133673002: Push API: Implement and ship PushSubscription.options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl

Issue 2133673002: Push API: Implement and ship PushSubscription.options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/push_messaging/PushSubscription.h ('K') | « third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.h » ('j') | third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl

index ccfb82729324060db6f03f38760ddb32f05dbdf5..bae659f6588d0becf4553ee8f444a96ff186bb73 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl

+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl

@@ -14,6 +14,7 @@ enum PushEncryptionKeyName {

RuntimeEnabled=PushMessaging,

] interface PushSubscription {

readonly attribute USVString endpoint;

+ [SameObject] readonly attribute PushSubscriptionOptions options;

ArrayBuffer? getKey(PushEncryptionKeyName name);

[CallWith=ScriptState] Promise<boolean> unsubscribe();